Review main Merged

58921[BUGFIX] Disable extension updates in Composer mode

Nicole Hummel CR +2 V +2 Easy +7 −2 updated 12/16/18, 20:58

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Wolfgang Klinger +1
    • Markus Klein +1
    • Jörg Bösche +1
  • Verified V +2
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1417

  1. Nicole Hummel uploaded patch set 1 11/20/18, 22:17

  2. Nicole Hummel updated the commit message in patch set 2 11/20/18, 22:18

  3. Nicole Hummel rebased onto patch set 3 11/20/18, 22:20

  4. Markus Klein commented on patch set 3 CR +1 11/20/18, 22:21

    still master, right?
  5. TYPO3com voted on patch set 1 V +1 11/20/18, 22:31 Completed build in 13m 04s on Tue, 20 Nov, 11:31 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30218

  6. TYPO3com voted on patch set 2 V +1 11/20/18, 22:32 Completed build in 13m 57s on Tue, 20 Nov, 11:32 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30219

  7. TYPO3com voted on patch set 3 V +1 11/20/18, 22:38 Completed build in 13m 40s on Tue, 20 Nov, 11:38 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30220

  8. Oliver Klee voted on patch set 3 CR +1 11/20/18, 22:44

  9. Josef Glatz voted on patch set 3 CR +1 11/22/18, 09:29

  10. Jörg Bösche commented on patch set 3 CR -1 11/22/18, 09:49

    ListController.php:147

    Could not find Environment::isComposerMode() in T3 v8.7. $isComposerMode = Bootstrap::usesComposerClassLoading(); for v8.7?
  11. Wolfgang Klinger commented on patch set 3 CR +1 11/25/18, 14:38

    @ Jörg This must imho be adapted by the one who merges the patch in the 8.7 branch. There is a constant TYPO3_COMPOSER_MODE available.
  12. Jörg Bösche commented on patch set 3 CR +1 11/25/18, 14:42

    Thanks for the explanation. Will change my -1 to +1.
  13. Markus Klein voted on patch set 3 V +1 12/03/18, 08:02

  14. Georg Ringer commented on patch set 3 V +2 CR +2 12/03/18, 20:32

    ListController.php:147 Reply

    code changed there a bit. it is Bootstrap::usesComposerClassLoading() there
  15. Georg Ringer merged patch set 4 12/03/18, 20:32

  16. Stephan Großberndt commented on patch set 4 12/14/18, 10:50

    What about the backport to 8.7? Please respond here.
  17. Markus Klein commented on patch set 4 12/16/18, 20:58

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit f499ab4563f730311e07ec0ac09f18c13e90bcbf