Review main Merged

58928[BUGFIX] Don't process ifEmpty/ifBlank stdWrap if content is available

Wolfgang Klinger CR +2 V +2 Easy +7 −0 updated 02/04/20, 13:08

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Wolfgang Klinger uploaded patch set 1 11/21/18, 19:35

  2. TYPO3com voted on patch set 1 V +1 11/21/18, 19:46 Completed build in 11m 12s on Wed, 21 Nov, 08:46 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30237

  3. Mona Muzaffar voted on patch set 1 V +1 CR +1 12/07/18, 13:05

  4. Josef Glatz voted on patch set 1 CR +1 12/07/18, 22:15

  5. Raphael Graf commented on patch set 1 CR -1 12/09/18, 09:47

    ContentObjectRenderer.php:1609

    The functions stdWrap_ifEmpty/stdWrap_ifBlank use trim($content) for these checks. And what about ifNull? (I don't think duplicating these checks is worth it)
  6. Benni Mack updated the commit message in patch set 2 12/14/18, 10:17

  7. Susi Moog rebased onto patch set 3 10/25/19, 18:30

  8. Susi Moog voted on patch set 3 V +1 CR +1 10/25/19, 18:31

  9. TYPO3com voted on patch set 3 V +1 10/25/19, 18:52 Completed build in 18m 31s on Fri, 25 Oct, 06:52 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37732

  10. Benni Mack voted on patch set 3 V +2 CR +2 11/04/19, 15:38

  11. Benni Mack merged patch set 4 11/04/19, 15:39

  12. Francois Suter commented on patch set 4 02/04/20, 13:08

    The check for "ifEmpty" is not correct. See comment.

    ContentObjectRenderer.php:1612 Unresolved

    This check is abusive. See my comment in https://forge.typo3.org/issues/86969