58935[BUGFIX] Fix nested arrays in conditions
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Anja Leichsenring +1
- Raphael Graf +1
-
Verified V +2
- Markus Klein +2
- Joerg Kummer +1
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 2836
Show 811 earlier messages
-
Wolfgang Klinger uploaded patch set 1 11/23/18, 12:24
-
TYPO3com voted on patch set 1 V +1 11/23/18, 12:34 Completed build in 10m 21s on Fri, 23 Nov, 01:34 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30253
-
Wolfgang Klinger updated the commit message in patch set 2 11/23/18, 12:41
-
TYPO3com voted on patch set 2 V +1 11/23/18, 13:07 Completed build in 17m 37s on Fri, 23 Nov, 02:07 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30257
-
Josef Glatz commented on patch set 2 V -1 CR -1 11/25/18, 06:03
Thanks Wolfgang! At a first glance it looks good. After extending the test scenario there's one more thing. I've added it as comment 6 in the issue https://forge.typo3.org/issues/86915#note-6 -
Wolfgang Klinger commented on patch set 2 11/25/18, 14:19
@ Josef: this one can't be fixed by TYPO3 if the parsing is completely left to symfony's expression language … because the symfony parser throws an exception if an array in a condition does not exist and therefor the whole condition fails (even if there's an OR condition like in your example … see \Symfony\Component\ExpressionLanguage\Node\GetAttrNode::evaluate for details) -
Josef Glatz voted on patch set 2 V 0 CR 0 11/29/18, 07:33
-
Frank Nägler commented on patch set 2 CR -1 12/02/18, 15:23
thanks for your path, I am on it an will push an update -
Frank Nägler uploaded patch set 3 12/02/18, 16:03
-
TYPO3com voted on patch set 3 V +1 12/02/18, 16:14 Completed build in 10m 44s on Sun, 2 Dec, 05:14 PM Test Summary: 48628 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30383
-
Wolfgang Klinger voted on patch set 3 V +1 CR +1 12/03/18, 06:27
-
Raphael Graf voted on patch set 3 CR +1 12/06/18, 17:12
-
Josef Glatz voted on patch set 3 V +1 CR +1 12/06/18, 17:53
-
Markus Klein commented on patch set 3 12/06/18, 18:00
ExpressionHelper.php:34why this variable, but no $andPattern?? -
Markus Klein commented on patch set 3 CR -1 12/06/18, 18:02
ExpressionHelper.php:32the OR part was optional before. mind the missing ? -
Markus Klein commented on patch set 3 12/06/18, 18:04
And I don't get why we need a dedicated class for that piece of code. The tests should be doable also for the condition matcher -
Markus Klein uploaded patch set 4 12/07/18, 00:51
-
Markus Klein uploaded patch set 5 12/07/18, 00:52
-
Markus Klein uploaded patch set 6 12/07/18, 00:54
-
Markus Klein commented on patch set 6 V +1 CR +1 12/07/18, 00:55
original implementation fails with the tests, new regex implementation can deal with nested [] -
Markus Klein uploaded patch set 7 12/07/18, 00:57
-
Markus Klein voted on patch set 7 V +1 CR +1 12/07/18, 00:58
-
Markus Klein updated the commit message in patch set 8 12/07/18, 01:01
-
Markus Klein voted on patch set 8 V +1 CR +1 12/07/18, 01:01
-
TYPO3com voted on patch set 4 V +1 12/07/18, 01:06 Completed build in 14m 43s on Fri, 7 Dec, 02:06 AM Test Summary: 48700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30486
-
TYPO3com voted on patch set 5 V +1 12/07/18, 01:09 Completed build in 16m 34s on Fri, 7 Dec, 02:09 AM Test Summary: 48700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30487
-
TYPO3com voted on patch set 6 V +1 12/07/18, 01:13 Completed build in 15m 32s on Fri, 7 Dec, 02:13 AM Test Summary: 48700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30488
-
TYPO3com voted on patch set 7 V +1 12/07/18, 01:18 Completed build in 20m 03s on Fri, 7 Dec, 02:18 AM Test Summary: 48700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30489
-
TYPO3com voted on patch set 8 V +1 12/07/18, 01:22 Completed build in 13m 38s on Fri, 7 Dec, 02:22 AM Test Summary: 48700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30490
-
Joerg Kummer voted on patch set 8 V +1 12/07/18, 07:13
-
Raphael Graf voted on patch set 8 CR +1 12/07/18, 11:48
-
Markus Klein voted on patch set 8 V +2 CR +2 12/07/18, 20:07
-
Markus Klein voted on patch set 8 V +1 CR +1 12/07/18, 20:12
-
Anja Leichsenring voted on patch set 8 V +1 CR +1 12/07/18, 20:18
-
Markus Klein voted on patch set 8 V +2 CR +2 12/07/18, 20:19
-
Markus Klein merged patch set 9 12/07/18, 20:19