Review main Merged

58935[BUGFIX] Fix nested arrays in conditions

Wolfgang Klinger CR +2 V +2 Normal +99 −12 updated 12/07/18, 20:19

Commit message

The RequestWrapper::getParsedBody method must return an array,
otherwise the a condition like [request.getParsedBody()['foo'] == 1]
results in a silent exception if the body is empty.

ConditionMatcher::normalizeExpression is now using an advanced regex
to handle multiple [] parts correctly.

Review

  • Code review CR +2
    • Markus Klein +2
    • Anja Leichsenring +1
    • Raphael Graf +1
  • Verified V +2
    • Markus Klein +2
    • Joerg Kummer +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2836

Show 811 earlier messages
  1. Wolfgang Klinger uploaded patch set 1 11/23/18, 12:24

  2. TYPO3com voted on patch set 1 V +1 11/23/18, 12:34 Completed build in 10m 21s on Fri, 23 Nov, 01:34 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30253

  3. Wolfgang Klinger updated the commit message in patch set 2 11/23/18, 12:41

  4. TYPO3com voted on patch set 2 V +1 11/23/18, 13:07 Completed build in 17m 37s on Fri, 23 Nov, 02:07 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30257

  5. Josef Glatz commented on patch set 2 V -1 CR -1 11/25/18, 06:03

    Thanks Wolfgang! At a first glance it looks good. After extending the test scenario there's one more thing. I've added it as comment 6 in the issue https://forge.typo3.org/issues/86915#note-6
  6. Wolfgang Klinger commented on patch set 2 11/25/18, 14:19

    @ Josef: this one can't be fixed by TYPO3 if the parsing is completely left to symfony's expression language … because the symfony parser throws an exception if an array in a condition does not exist and therefor the whole condition fails (even if there's an OR condition like in your example … see \Symfony\Component\ExpressionLanguage\Node\GetAttrNode::evaluate for details)
  7. Josef Glatz voted on patch set 2 V 0 CR 0 11/29/18, 07:33

  8. Frank Nägler commented on patch set 2 CR -1 12/02/18, 15:23

    thanks for your path, I am on it an will push an update
  9. Frank Nägler uploaded patch set 3 12/02/18, 16:03

  10. TYPO3com voted on patch set 3 V +1 12/02/18, 16:14 Completed build in 10m 44s on Sun, 2 Dec, 05:14 PM Test Summary: 48628 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30383

  11. Wolfgang Klinger voted on patch set 3 V +1 CR +1 12/03/18, 06:27

  1. Raphael Graf voted on patch set 3 CR +1 12/06/18, 17:12

  2. Josef Glatz voted on patch set 3 V +1 CR +1 12/06/18, 17:53

  3. Markus Klein commented on patch set 3 12/06/18, 18:00

    ExpressionHelper.php:34

    why this variable, but no $andPattern??
  4. Markus Klein commented on patch set 3 CR -1 12/06/18, 18:02

    ExpressionHelper.php:32

    the OR part was optional before. mind the missing ?
  5. Markus Klein commented on patch set 3 12/06/18, 18:04

    And I don't get why we need a dedicated class for that piece of code. The tests should be doable also for the condition matcher
  6. Markus Klein uploaded patch set 4 12/07/18, 00:51

  7. Markus Klein uploaded patch set 5 12/07/18, 00:52

  8. Markus Klein uploaded patch set 6 12/07/18, 00:54

  9. Markus Klein commented on patch set 6 V +1 CR +1 12/07/18, 00:55

    original implementation fails with the tests, new regex implementation can deal with nested []
  10. Markus Klein uploaded patch set 7 12/07/18, 00:57

  11. Markus Klein voted on patch set 7 V +1 CR +1 12/07/18, 00:58

  12. Markus Klein updated the commit message in patch set 8 12/07/18, 01:01

  13. Markus Klein voted on patch set 8 V +1 CR +1 12/07/18, 01:01

  14. TYPO3com voted on patch set 4 V +1 12/07/18, 01:06 Completed build in 14m 43s on Fri, 7 Dec, 02:06 AM Test Summary: 48700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30486

  15. TYPO3com voted on patch set 5 V +1 12/07/18, 01:09 Completed build in 16m 34s on Fri, 7 Dec, 02:09 AM Test Summary: 48700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30487

  16. TYPO3com voted on patch set 6 V +1 12/07/18, 01:13 Completed build in 15m 32s on Fri, 7 Dec, 02:13 AM Test Summary: 48700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30488

  17. TYPO3com voted on patch set 7 V +1 12/07/18, 01:18 Completed build in 20m 03s on Fri, 7 Dec, 02:18 AM Test Summary: 48700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30489

  18. TYPO3com voted on patch set 8 V +1 12/07/18, 01:22 Completed build in 13m 38s on Fri, 7 Dec, 02:22 AM Test Summary: 48700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30490

  19. Joerg Kummer voted on patch set 8 V +1 12/07/18, 07:13

  20. Raphael Graf voted on patch set 8 CR +1 12/07/18, 11:48

  21. Markus Klein voted on patch set 8 V +2 CR +2 12/07/18, 20:07

  22. Markus Klein voted on patch set 8 V +1 CR +1 12/07/18, 20:12

  23. Anja Leichsenring voted on patch set 8 V +1 CR +1 12/07/18, 20:18

  24. Markus Klein voted on patch set 8 V +2 CR +2 12/07/18, 20:19

  25. Markus Klein merged patch set 9 12/07/18, 20:19