Review main Merged

58942[BUGFIX] Only show pages of current language in XML sitemap

Richard Haeser CR +2 V +2 Easy +4 −4 updated 12/03/18, 19:57

Commit message

Because pages of other languages have the page id of the default language
as the parent id, we need to search for the default language only pages
to show up in the initial pagetree.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Richard Haeser +1
  • Verified V +2
    • Georg Ringer +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 2026

Show 1 earlier messages
  1. Richard Haeser uploaded patch set 1 11/23/18, 20:49

  1. TYPO3com voted on patch set 1 V +1 11/23/18, 21:00 Completed build in 10m 52s on Fri, 23 Nov, 10:00 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30264

  2. Benni Mack commented on patch set 1 11/24/18, 14:01

    PagesXmlSitemapDataProvider.php:88

    I'd recommend using cObj->getTreeList() instead btw.
  3. Richard Haeser uploaded patch set 2 11/25/18, 15:54

  4. TYPO3com voted on patch set 2 V +1 11/25/18, 16:06 Completed build in 11m 16s on Sun, 25 Nov, 05:06 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30274

  5. Alexander Grein voted on patch set 2 V +1 CR +1 11/27/18, 10:09

  6. Benni Mack commented on patch set 2 CR -1 11/28/18, 06:57

    PagesXmlSitemapDataProvider.php:94

    this is not cool.... will fix a different bugfix for that.
  7. Richard Haeser commented on patch set 2 11/28/18, 07:01

    PagesXmlSitemapDataProvider.php:94 Reply

    I already had a look at it, but wasn't sure I could come up with a non-breaking fix for this. It would be great if you could create a fix for this!
  8. Benni Mack commented on patch set 2 11/28/18, 07:03

    See https://review.typo3.org/#/c/58967/ - please remove the additional where clause in this patch.
  9. Richard Haeser commented on patch set 2 11/28/18, 07:12

  10. Richard Haeser uploaded patch set 3 11/28/18, 07:19

  11. Richard Haeser uploaded patch set 4 11/28/18, 07:23

  12. TYPO3com voted on patch set 3 V +1 11/28/18, 07:41 Completed build in 17m 07s on Wed, 28 Nov, 08:41 AM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30322

  13. TYPO3com voted on patch set 4 V +1 11/28/18, 08:03 Completed build in 39m 23s on Wed, 28 Nov, 09:03 AM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30323

  14. Markus Klein voted on patch set 4 CR +1 11/29/18, 07:33

  15. Benni Mack commented on patch set 4 11/29/18, 07:45

    PagesXmlSitemapDataProvider.php:93

    check the following - "if you dump in "-$rootPageId" into getTreeList() the rootpage ID is added to the treeList automatically and also checked for mount points... (just by reading cObj->getTreeList() docs)
  16. Guido Schmechel commented on patch set 4 11/29/18, 07:58

    PagesXmlSitemapDataProvider.php:90 Unresolved

    Do we need the full level query (99) if we use the recursive option?
  17. Richard Haeser uploaded patch set 5 11/30/18, 20:13

  18. Richard Haeser commented on patch set 5 11/30/18, 20:14

    > (1 comment) You want all levels to show up in your sitemap, so yes we need the full level query IMO.
  19. TYPO3com voted on patch set 5 V +1 11/30/18, 20:23 Completed build in 10m 18s on Fri, 30 Nov, 09:23 PM Test Summary: 48496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30377

  20. Markus Klein commented on patch set 5 12/03/18, 08:17

    PagesXmlSitemapDataProvider.php:96

    readability nitpick: that should still fit into a single line. ;-)
  21. Markus Klein commented on patch set 6 12/03/18, 08:17

    Published edit on patch set 5.
  22. TYPO3com voted on patch set 6 V +1 12/03/18, 08:30 Completed build in 13m 00s on Mon, 3 Dec, 09:30 AM Test Summary: 48496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30386

  23. Richard Haeser voted on patch set 6 V +1 CR +1 12/03/18, 11:26

  24. Georg Ringer voted on patch set 6 V +2 CR +2 12/03/18, 19:57

  25. Georg Ringer merged patch set 7 12/03/18, 19:57