Review main Merged

58944[BUGFIX] Update SYS_LASTCHANGED for the right language page record

Wolfgang Klinger CR +2 V +2 Easy +24 −7 updated 03/24/19, 10:26

Commit message

The register SYS_LASTCHANGED needs to reflect the
value of the translated page as well.

This is now done properly in a separate method.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1116

  1. Wolfgang Klinger uploaded patch set 1 11/24/18, 17:34

  2. TYPO3com voted on patch set 1 V +1 11/24/18, 17:44 Completed build in 10m 36s on Sat, 24 Nov, 06:44 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30267

  3. Edward A. Gabdullin commented on patch set 1 03/11/19, 10:12

    > Patch Set 1: Verified+1 > > Completed build in 10m 36s on Sat, 24 Nov, 06:44 PM > Test Summary: 48484 passed > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30267 For TYPO 9.5.5 patch does not work
  4. Wolfgang Klinger uploaded patch set 2 03/12/19, 06:41

  5. Wolfgang Klinger updated the commit message in patch set 3 03/12/19, 06:42

  6. TYPO3com voted on patch set 2 V +1 03/12/19, 06:56 Completed build in 14m 38s on Tue, 12 Mar, 07:56 AM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32669

  7. TYPO3com voted on patch set 3 V +1 03/12/19, 06:57 Completed build in 14m 48s on Tue, 12 Mar, 07:57 AM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32670

  8. Georg Ringer commented on patch set 3 03/15/19, 21:20

    TypoScriptFrontendController.php:2556 Unresolved

    that should not be needed, please use the phpstorm plugin http://plugins.jetbrains.com/plugin/7251

    TypoScriptFrontendController.php:2560 Unresolved

    just wanna use the ternary operator?
  9. Wolfgang Klinger uploaded patch set 4 03/15/19, 21:55

  10. TYPO3com voted on patch set 4 V +1 03/15/19, 22:09 Completed build in 14m 24s on Fri, 15 Mar, 11:09 PM Test Summary: 47215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32776

  11. Benni Mack uploaded patch set 5 03/23/19, 21:32

  12. Benni Mack voted on patch set 5 V +1 CR +1 03/23/19, 21:32

  13. TYPO3com voted on patch set 5 V +1 03/23/19, 21:46 Completed build in 14m 07s on Sat, 23 Mar, 10:46 PM Test Summary: 47217 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32912

  14. Andreas Kienast voted on patch set 5 CR +1 03/23/19, 22:12

  15. Daniel Goerz voted on patch set 5 V +2 CR +2 03/24/19, 10:26

  16. Daniel Goerz merged patch set 6 03/24/19, 10:26