Review main Merged

58945[BUGFIX] Fix stdWrap.replacement boolean properties handling

Wolfgang Klinger CR +2 V +2 Normal +26 −25 updated 11/04/19, 16:21

Commit message

Cast the properties useRegExp and useOptionSplitReplace
to boolean and fix the if condition logic.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 69

  1. Wolfgang Klinger uploaded patch set 1 11/24/18, 18:52

  2. TYPO3com voted on patch set 1 V +1 11/24/18, 19:02 Completed build in 10m 13s on Sat, 24 Nov, 08:02 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30269

  3. Benni Mack updated the commit message in patch set 2 12/14/18, 10:12

  4. Susi Moog voted on patch set 2 V +1 CR +1 10/25/19, 18:16

  5. TYPO3com voted on patch set 2 V -1 11/04/19, 15:36 Completed build in 13m 04s on Mon, 4 Nov, 03:36 PM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37982

  6. Benni Mack voted on patch set 2 CR +1 11/04/19, 15:41

  7. TYPO3com voted on patch set 2 V +1 11/04/19, 15:49 Completed build in 39m 05s on Mon, 4 Nov, 03:49 PM Test Summary: 48078 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37982

  8. Benni Mack voted on patch set 2 V +2 CR +2 11/04/19, 16:21

  9. Benni Mack merged patch set 3 11/04/19, 16:21