Review main Merged

58946[BUGFIX] Fix parseFunc handling of nested tags

Wolfgang Klinger CR +2 V +2 Hard +385 −14 updated 03/02/20, 07:51

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2230

Show 35 earlier messages
  1. Wolfgang Klinger uploaded patch set 1 11/25/18, 10:46

  2. TYPO3com voted on patch set 1 V -1 11/25/18, 10:47 Completed build in 18s on Sun, 25 Nov, 11:47 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30270

  3. Wolfgang Klinger uploaded patch set 2 11/25/18, 10:49

  4. TYPO3com voted on patch set 2 V +1 11/25/18, 11:00 Completed build in 11m 11s on Sun, 25 Nov, 12:00 PM Test Summary: 48492 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30271

  5. Riccardo De Contardi commented on patch set 2 V -1 11/25/18, 22:05

    tested with latest master and the code reported on the issue.
  1. Wolfgang Klinger commented on patch set 2 11/26/18, 07:46

    @Riccardo: please review your test, because the code reported in the issue is the same as in the ContentObjectRenderTest and it passes. Otherwise please provide more information what failed.
  2. Riccardo De Contardi commented on patch set 2 V +1 11/26/18, 08:27

    @Wolfgang Klinger you are right, my fault. The code works. Sorry for the inconvenience
  3. Benni Mack updated the commit message in patch set 3 12/14/18, 10:12

  4. Frank Nägler uploaded patch set 4 08/08/19, 10:38

  5. Frank Nägler commented on patch set 4 CR -1 08/08/19, 10:39

    I have added three additional test cases which shows, that the code is still broken. sry for the bad news, but this patch is not ready yet.
  6. Oliver Klee commented on patch set 4 08/08/19, 10:48

    ContentObjectRenderer.php:3793

    Please let's extract this into a well-name method so this (already too long) method does not get much longer.
  7. TYPO3com voted on patch set 4 V -1 08/08/19, 10:49 Completed build in 11m 25s on Thu, 8 Aug, 10:49 AM Test Summary: 12 of 47551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35646

  8. Frank Nägler commented on patch set 4 10/10/19, 12:15

    oh, and I think this should go only into master, because this change could break existing frontends.
  9. Henning Liebe uploaded patch set 5 10/11/19, 11:26

  10. TYPO3com voted on patch set 5 V -1 10/11/19, 11:35 Completed build in 08m 39s on Fri, 11 Oct, 11:35 AM Test Summary: 47767 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37252

  11. TYPO3com commented on patch set 5 10/11/19, 11:56 Completed build in 09m 57s on Fri, 11 Oct, 11:56 AM Test Summary: 1 of 48377 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37253

  12. TYPO3com voted on patch set 5 V +1 10/11/19, 12:07 Completed build in 10m 12s on Fri, 11 Oct, 12:07 PM Test Summary: 48018 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37254

  13. Henning Liebe commented on patch set 5 10/11/19, 12:16

    Fixed broken Tests and extracted code to a new method

    Reply

    Done

    ContentObjectRenderer.php:3793 Reply

    Done
  14. Tobi Kretschmann voted on patch set 5 CR +1 10/11/19, 12:22

  15. Benni Mack uploaded patch set 6 12/27/19, 21:19

  16. Benni Mack voted on patch set 6 CR +1 12/27/19, 21:21

  17. TYPO3com voted on patch set 6 V +1 12/27/19, 22:09 Completed build in 39m 57s on Fri, 27 Dec, 10:09 PM Test Summary: 69182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39622

  18. Tobi Kretschmann voted on patch set 6 CR +1 01/13/20, 10:00

  19. Susi Moog uploaded patch set 7 02/28/20, 07:10

  20. Susi Moog commented on patch set 7 02/28/20, 07:11

    resolved merge conflicts
  21. TYPO3com voted on patch set 7 V +1 02/28/20, 07:21 Completed build in 10m 52s on Fri, 28 Feb, 07:21 AM Test Summary: 72057 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-766

  22. Susi Moog voted on patch set 7 CR +1 02/28/20, 08:27

  23. Georg Ringer voted on patch set 7 V +1 CR +1 02/28/20, 08:48

  24. Benni Mack voted on patch set 7 V +2 CR +2 03/02/20, 07:51

  25. Benni Mack merged patch set 8 03/02/20, 07:51