Review main Merged

58953[BUGFIX] Enlarge scheduler object DB field

Benni Mack CR +2 V +2 Easy +2 −2 updated 11/26/18, 16:25

Commit message

The serialized PHP object is stored within the database field
"serialized_task_object". When serializing this could lead to several
issues.

One particular issue is that the object has lots of data or dependencies,
it cannot be stored at all in this database field.

Although we know that this implementation detail of scheduler is a rather
bad idea, we can only fix this by enlarging the field from "blob" to
"mediumblob" for now.

Review

  • Code review CR +2
    • Markus Klein +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Riny van Tiggelen +1
    • Andreas Kienast +1
  • Verified V +2
    • Markus Klein +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Benni Mack uploaded patch set 1 11/26/18, 14:50

  2. TYPO3com voted on patch set 1 V +1 11/26/18, 15:02 Completed build in 11m 34s on Mon, 26 Nov, 04:02 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30294

  3. Riny van Tiggelen voted on patch set 1 CR +1 11/26/18, 15:07

  4. Oliver Klee voted on patch set 1 CR +1 11/26/18, 15:16

  5. Georg Ringer voted on patch set 1 V +1 CR +1 11/26/18, 15:18

  6. Andreas Kienast voted on patch set 1 CR +1 11/26/18, 16:01

  7. Markus Klein voted on patch set 1 V +2 CR +2 11/26/18, 16:24

  8. Markus Klein merged patch set 2 11/26/18, 16:25

  9. Markus Klein commented on patch set 2 11/26/18, 16:25

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ac0964848042a5cda4bee6715617e8bdf9848746