Review main Merged

58956[BUGFIX] Revert UrlEncoding for GeneralUtility functions

Anja Leichsenring CR +2 V +2 Easy +6 −3 updated 12/07/18, 14:42

Commit message

URLencoding applied to linkThisScript and linkThisUrl make
links fail that are only used and executed by Javascript.
Reverting to old behavior fixes the failure.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Richard Haeser +1
    • Andreas Kienast +1
    • Mona Muzaffar +1
    • Benni Mack +1
  • Verified V +2
    • Anja Leichsenring +2
    • Preben Sørensen +1
    • Joerg Kummer +1
    • Richard Haeser +1
    • Benni Mack +1
    • Tim Karliczek +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2226

Show 1 earlier messages
  1. Anja Leichsenring uploaded patch set 1 11/26/18, 20:47

  1. Joerg Kummer voted on patch set 1 V +1 CR +1 11/26/18, 20:56

  2. TYPO3com voted on patch set 1 V +1 11/26/18, 20:57 Completed build in 10m 26s on Mon, 26 Nov, 09:57 PM Test Summary: 48479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30300

  3. Joerg Kummer commented on patch set 1 11/26/18, 21:05

    Should a paste action from default clipboard not emty the clipboard at the same time, if I use a clipboard element? I think this was the old behaviour. Not shure. But shure that this is not the problem with this patch.
  4. Preben Sørensen voted on patch set 1 V +1 CR +1 11/27/18, 12:50

  5. Anja Leichsenring commented on patch set 1 CR -2 11/27/18, 13:50

    solution not satisfying, I will revert to the original state. Please hold the line ...
  6. Anja Leichsenring uploaded patch set 2 11/27/18, 20:05

  7. Anja Leichsenring voted on patch set 2 CR 0 11/27/18, 20:05

  8. TYPO3com voted on patch set 2 V +1 11/27/18, 20:19 Completed build in 13m 51s on Tue, 27 Nov, 09:19 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30317

  9. Joerg Kummer voted on patch set 2 V +1 11/28/18, 00:17

  10. Benni Mack commented on patch set 2 11/28/18, 06:56

    GeneralUtility.php:2643

    I think the same is for "linkThisUrl()" here.
  11. Preben Sørensen voted on patch set 2 V +1 11/29/18, 19:14

  12. Anja Leichsenring uploaded patch set 3 12/04/18, 08:00

  13. Anja Leichsenring updated the commit message in patch set 4 12/04/18, 08:01

  14. TYPO3com voted on patch set 3 V +1 12/04/18, 08:13 Completed build in 13m 02s on Tue, 4 Dec, 09:13 AM Test Summary: 48548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30417

  15. TYPO3com voted on patch set 4 V +1 12/04/18, 08:16 Completed build in 13m 10s on Tue, 4 Dec, 09:16 AM Test Summary: 48548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30418

  16. Joerg Kummer voted on patch set 4 V +1 12/04/18, 10:25

  17. Preben Sørensen voted on patch set 4 V +1 12/04/18, 10:41

  18. Tim Karliczek voted on patch set 4 V +1 12/04/18, 16:49

  19. Benni Mack voted on patch set 4 V +1 CR +1 12/04/18, 19:38

  20. Mona Muzaffar voted on patch set 4 CR +1 12/07/18, 10:49

  21. Richard Haeser voted on patch set 4 CR +1 12/07/18, 14:32

  22. Andreas Kienast voted on patch set 4 CR +1 12/07/18, 14:33

  23. Richard Haeser voted on patch set 4 V +1 12/07/18, 14:39

  24. Anja Leichsenring voted on patch set 4 V +2 CR +2 12/07/18, 14:42

  25. Anja Leichsenring merged patch set 5 12/07/18, 14:42