Review main Merged

58960[TASK] Log a warning if fluid-based preview template couldn't be rendered

Josef Glatz CR +2 V +2 Easy +6 −1 updated 11/27/18, 14:49

Commit message

A warning is logged if the fluid-based preview template for a
content element could not be rendered.

The logged warning includes
- the UID of the content element
- the resulting path to the template file
- and the exception message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Alexander Grein +1
    • Mathias Brodala +1
  • Verified V +2
    • Georg Ringer +2
    • Alexander Grein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1217

  1. Josef Glatz uploaded patch set 1 11/27/18, 12:25

  2. Josef Glatz updated the commit message in patch set 2 11/27/18, 12:27

  3. TYPO3com voted on patch set 1 V +1 11/27/18, 12:40 Completed build in 14m 31s on Tue, 27 Nov, 01:40 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30303

  4. TYPO3com voted on patch set 2 V +1 11/27/18, 12:49 Completed build in 14m 16s on Tue, 27 Nov, 01:49 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30304

  5. Josef Glatz updated the commit message in patch set 3 11/27/18, 12:54

  6. Josef Glatz updated the commit message in patch set 4 11/27/18, 13:01

  7. Josef Glatz commented on patch set 4 11/27/18, 13:03

    8.7 patch will come as a follow up if this was merged. Plan is to simply log to sys_log in 8.7, because there is not the same logger.
  8. Josef Glatz wrote 11/27/18, 13:04

    Removed reviewer Josef Glatz.
  9. Georg Ringer voted on patch set 4 V +1 CR +1 11/27/18, 13:06

  10. Mathias Brodala commented on patch set 5 11/27/18, 13:06

    Published edit on patch set 4.
  11. Mathias Brodala commented on patch set 5 CR +1 11/27/18, 13:07

    Tweaked message to ensure odd template filenames can still be recognized.
  12. TYPO3com voted on patch set 3 V +1 11/27/18, 13:09 Completed build in 15m 03s on Tue, 27 Nov, 02:09 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30305

  13. TYPO3com commented on patch set 4 11/27/18, 13:23 Completed build in 18m 56s on Tue, 27 Nov, 02:23 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30306

  14. TYPO3com voted on patch set 5 V +1 11/27/18, 13:32 Completed build in 15m 51s on Tue, 27 Nov, 02:32 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30307

  15. Alexander Grein voted on patch set 5 V +1 CR +1 11/27/18, 14:41

  16. Georg Ringer voted on patch set 5 V +2 CR +2 11/27/18, 14:49

  17. Georg Ringer merged patch set 6 11/27/18, 14:49