Review TYPO3_8-7 Merged

58966[TASK] Log a warning if fluid-based preview template couldn't be rendered

Josef Glatz CR +2 V +2 Easy +10 −1 updated 12/04/18, 07:29

Commit message

A warning is logged if the fluid-based preview template for a
content element could not be rendered.

The logged warning includes
- the UID of the content element
- the resulting path to the template file
- and the exception message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Jérémie Roulin +1
  • Verified V +2
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Josef Glatz uploaded patch set 1 11/28/18, 04:42

  2. TYPO3com voted on patch set 1 V -1 11/28/18, 04:42 Completed build in 10s on Wed, 28 Nov, 05:42 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3218

  3. Josef Glatz uploaded patch set 2 11/28/18, 04:45

  4. TYPO3com voted on patch set 2 V +1 11/28/18, 04:57 Completed build in 11m 26s on Wed, 28 Nov, 05:56 AM Test Summary: 79286 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3219

  5. Georg Ringer voted on patch set 2 V +1 CR +1 11/29/18, 18:03

  6. Jonas Eberle commented on patch set 2 11/30/18, 10:49

    PageLayoutView.php:1793

    I suggest also an $out = ... ("look at the log" or just the same as in the sprintf) here because it would make this error more obvious. I guess there is no other error shown yet so an integrator would just see that his expected content is mising?
  7. Josef Glatz commented on patch set 2 11/30/18, 11:06

    PageLayoutView.php:1793 Reply

    Nice idea. But as this is only a backport/ cherrypick your idea must be another ptch
  8. Jonas Eberle commented on patch set 2 11/30/18, 11:07

    Ah, sorry. Didn't see that.
  9. Georg Ringer voted on patch set 2 V +2 CR +2 12/04/18, 04:34

  10. Georg Ringer merged patch set 3 12/04/18, 04:34

  11. Jérémie Roulin voted on patch set 3 CR +1 12/04/18, 07:29