Review main Merged

58967[BUGFIX] Only fetch default language page for tree lists

Benni Mack CR +2 V +2 Easy +9 −2 updated 11/29/18, 07:34

Commit message

Due to the removal of pages_language_overlay the queries
for fetching trees have to work as before - mainly because the
concept of the "pid" (= storagePid) works the same - records on a
page have the pid of the default language, not of any translation.

Therefore, the used queries have to be built to check for
sys_language_uid=0.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Richard Haeser +1
  • Verified V +2
    • Anja Leichsenring +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 710

  1. Benni Mack uploaded patch set 1 11/28/18, 07:02

  2. Richard Haeser updated the commit message in patch set 2 11/28/18, 07:12

  3. Richard Haeser updated the commit message in patch set 3 11/28/18, 07:16

  4. TYPO3com voted on patch set 1 V +1 11/28/18, 07:17 Completed build in 14m 39s on Wed, 28 Nov, 08:17 AM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30319

  5. Richard Haeser voted on patch set 3 V +1 CR +1 11/28/18, 07:18

  6. TYPO3com voted on patch set 2 V +1 11/28/18, 07:28 Completed build in 16m 38s on Wed, 28 Nov, 08:28 AM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30320

  7. TYPO3com voted on patch set 3 V +1 11/28/18, 07:53 Completed build in 29m 03s on Wed, 28 Nov, 08:53 AM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30321

  8. Anja Leichsenring voted on patch set 3 V +2 CR +2 11/28/18, 09:57

  9. Anja Leichsenring merged patch set 4 11/28/18, 09:57

  10. Markus Klein commented on patch set 4 11/29/18, 07:34

    Sad we don't have tests for this complicated method.