Review main Merged

58972[BUGFIX] Allow accessing object from `ObjectStorage` with numeric value

Romain Canon CR +2 V +2 Normal +111 −19 updated 09/20/19, 12:23

Commit message

The following code now works:

```php
$objectStorage = new \TYPO3\CMS\Extbase\Persistence\ObjectStorage();
$objectStorage->attach(new \stdClass());
$myObject = $objectStorage->offsetGet(0);
```

And more importantly, the following Fluid code works as well:

<f:image image="{myObject.resources.0}" alt="My image!" />

Review

  • Code review CR +2
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1218

  1. Romain Canon uploaded patch set 1 11/28/18, 16:53

  2. TYPO3com voted on patch set 1 V -1 11/28/18, 17:07 Completed build in 14m 32s on Wed, 28 Nov, 06:07 PM Test Summary: 48496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30334

  3. Daniel Siepmann uploaded patch set 2 11/29/18, 08:00

  4. Daniel Siepmann voted on patch set 1 CR +1 11/29/18, 08:00

  5. TYPO3com voted on patch set 2 V +1 11/29/18, 08:12 Completed build in 11m 35s on Thu, 29 Nov, 09:12 AM Test Summary: 48496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30339

  6. Romain Canon uploaded patch set 3 11/29/18, 09:43

  7. TYPO3com voted on patch set 3 V -1 11/29/18, 09:53 Completed build in 10m 38s on Thu, 29 Nov, 10:53 AM Test Summary: 48496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30343

  8. Romain Canon uploaded patch set 4 11/29/18, 10:02

  9. TYPO3com voted on patch set 4 V -1 11/29/18, 10:14 Completed build in 12m 47s on Thu, 29 Nov, 11:14 AM Test Summary: 48496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30344

  10. Benni Mack uploaded patch set 5 11/29/18, 13:36

  11. Benni Mack updated the commit message in patch set 6 11/29/18, 13:36

  12. TYPO3com voted on patch set 5 V +1 11/29/18, 13:49 Completed build in 13m 33s on Thu, 29 Nov, 02:49 PM Test Summary: 48508 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30352

  13. TYPO3com voted on patch set 6 V +1 11/29/18, 13:52 Completed build in 16m 03s on Thu, 29 Nov, 02:52 PM Test Summary: 48508 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30353

  14. Benni Mack voted on patch set 6 V +1 CR +1 11/29/18, 16:06

  15. Georg Ringer voted on patch set 6 V +2 CR +2 12/03/18, 21:09

  16. Georg Ringer merged patch set 7 12/03/18, 21:09

  17. Stephan Großberndt commented on patch set 7 12/14/18, 10:50

    What about the backport to 8.7? Please respond here.
  18. Georg Ringer commented on patch set 7 09/20/19, 12:23

    No backport will be done for 8