58976[FEATURE] Allow to override htmlTag attributes
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Josef Glatz +1
- Georg Ringer +1
- Benjamin Kott +1
-
Verified V +2
- Benni Mack +2
- Georg Ringer +1
- Benjamin Kott +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-87033-NewTypoScriptPropertyConfightmlTagattributes.rstnew+44 −0
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+46 −9
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+15 −3
- typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php+65 −0
Review log 1214
-
Benni Mack uploaded patch set 1 11/29/18, 06:46
-
TYPO3com voted on patch set 1 V +1 11/29/18, 06:58 Completed build in 11m 44s on Thu, 29 Nov, 07:58 AM Test Summary: 48516 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30337
-
Soren Malling commented on patch set 1 11/29/18, 13:12
Just curious and to make sure it's head - but would it make sense to add the `lang` attribute via default typoscript. So the `config.htmlTag.attributes.lang = gettext:site:lang` (pseudo example) is set by default and possible to be overriden/disabled by integrators choice. -
Benni Mack commented on patch set 1 11/29/18, 14:03
Hey Soren, "lang" attribute is automatically added due to site handling. No TypoScript needed. No change through this patch. -
Soren Malling commented on patch set 1 CR +1 11/29/18, 14:05
I am aware of that :-) My suggestion was to move it from the sitehandling into the typoscript feature implemented by this patch. But I can see that as a separate changeset/suggestion later on when this feature is merged. -
Benni Mack commented on patch set 1 11/29/18, 14:24
The good thing is - you can override it now. it's just set by default. -
Soren Malling commented on patch set 1 11/29/18, 14:28
Completely agree :) Code review done from my side. Might have access to my test insstallation later this evening and will do functional review -
Josef Glatz commented on patch set 2 11/30/18, 19:54
Published edit on patch set 1. -
Josef Glatz voted on patch set 2 CR +1 11/30/18, 20:00
-
TYPO3com voted on patch set 2 V +1 11/30/18, 20:05 Completed build in 10m 48s on Fri, 30 Nov, 09:05 PM Test Summary: 48528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30376
-
Georg Ringer voted on patch set 2 V +1 CR +1 12/03/18, 18:02
-
Benjamin Kott voted on patch set 2 V +1 CR +1 12/03/18, 19:46
-
Benni Mack voted on patch set 2 V +2 CR +2 12/03/18, 19:47
-
Benni Mack merged patch set 3 12/03/18, 19:47