58983[BUGFIX] Fix indexing of pages using route enhancers
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Hendrik Helmken +1
- Alexander Grein +1
-
Verified V +2 Done
- Benni Mack +2
- Hendrik Helmken +1
- Alexander Grein +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/core/Documentation/Changelog/9.5.x/Important-86994-IndexedSearchWithRouteEnhancers.rstnew+21 −0
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php1+5 −1
- typo3/sysext/indexed_search/Classes/Domain/Repository/AdministrationRepository.php+2 −0
- typo3/sysext/indexed_search/Classes/Indexer.php3+18 −2
- typo3/sysext/indexed_search/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Pages.html+8 −0
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Statistic.html+38 −40
- typo3/sysext/indexed_search/ext_tables.sql+1 −0
Review log 3854
Show 2029 earlier messages
-
Alexander Grein uploaded patch set 1 11/29/18, 14:24
-
TYPO3com voted on patch set 1 V -1 11/29/18, 14:24 Completed build in 10s on Thu, 29 Nov, 03:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30354
-
Alexander Grein uploaded patch set 2 11/29/18, 14:37
-
TYPO3com voted on patch set 2 V +1 11/29/18, 14:48 Completed build in 10m 47s on Thu, 29 Nov, 03:48 PM Test Summary: 48496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30355
-
Josef Glatz commented on patch set 2 CR -1 11/30/18, 11:26
Commit message linebreaks needs to be adjusted -
Josef Glatz updated the commit message in patch set 3 11/30/18, 13:36
-
TYPO3com voted on patch set 3 V +1 11/30/18, 13:49 Completed build in 12m 58s on Fri, 30 Nov, 02:49 PM Test Summary: 48496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30371
-
Josef Glatz commented on patch set 3 11/30/18, 13:52
Do we have to inform the schema change? or any special update script? -
Alexander Grein commented on patch set 3 12/03/18, 14:18
> Patch Set 3: > > (1 comment) Not mandatory, because of the different phash and phash_grouping parameter calculation a page will be reindexed in the worst case. But a hint that a reindexing is necessary if EXT:crawler is in the game whould make sense. -
Alexander Grein uploaded patch set 4 12/04/18, 19:37
-
TYPO3com voted on patch set 4 V -1 12/04/18, 19:50 Completed build in 13m 10s on Tue, 4 Dec, 08:50 PM Test Summary: 48548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30447
-
Alexander Grein uploaded patch set 5 12/04/18, 20:42
-
TYPO3com voted on patch set 5 V +1 12/04/18, 20:54 Completed build in 12m 21s on Tue, 4 Dec, 09:54 PM Test Summary: 48548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30450
-
Josef Glatz commented on patch set 5 CR -1 01/30/19, 08:19
Alex, pls could you take care of your patch set 5? there is no code in it anymore -
Hendrik Helmken uploaded patch set 6 02/22/19, 10:35
-
TYPO3com voted on patch set 6 V +1 02/22/19, 10:48 Completed build in 12m 41s on Fri, 22 Feb, 11:48 AM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32338
-
Alexander Grein voted on patch set 6 V +1 CR +1 02/24/19, 12:35
-
Benni Mack commented on patch set 6 02/24/19, 13:24
Indexer.php:1441can we use json_encode/json_decode instead? -
Alexander Grein uploaded patch set 7 02/24/19, 18:17
-
TYPO3com voted on patch set 7 V +1 02/24/19, 18:28 Completed build in 10m 14s on Sun, 24 Feb, 07:28 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32389
-
Hendrik Helmken voted on patch set 7 V +1 CR +1 02/27/19, 13:39
-
Hendrik Helmken updated the commit message in patch set 8 02/28/19, 14:33
-
TYPO3com voted on patch set 8 V +1 02/28/19, 14:46 Completed build in 13m 12s on Thu, 28 Feb, 03:46 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32421
-
Benni Mack commented on patch set 8 02/28/19, 15:07
In general, this looks great, except one last minor remark.SearchController.php:1335Unresolvedshould we have array_merge_recursive() here? -
Benni Mack uploaded patch set 9 02/28/19, 15:37
-
Benni Mack voted on patch set 9 CR +1 02/28/19, 15:37
-
TYPO3com voted on patch set 9 V +1 02/28/19, 15:49 Completed build in 11m 43s on Thu, 28 Feb, 04:49 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32422
-
Hendrik Helmken voted on patch set 9 V +1 CR +1 02/28/19, 19:33
-
Benni Mack uploaded patch set 10 02/28/19, 20:28
-
Benni Mack uploaded patch set 11 02/28/19, 20:29
-
Benni Mack voted on patch set 11 V +1 CR +1 02/28/19, 20:29
-
TYPO3com voted on patch set 10 V +1 02/28/19, 20:44 Completed build in 15m 48s on Thu, 28 Feb, 09:44 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32428
-
TYPO3com voted on patch set 11 V +1 02/28/19, 20:45 Completed build in 15m 58s on Thu, 28 Feb, 09:45 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32429
-
Hendrik Helmken voted on patch set 11 V +1 CR +1 02/28/19, 20:46
-
Benni Mack uploaded patch set 12 02/28/19, 21:00
-
Benni Mack voted on patch set 12 V +1 CR +1 02/28/19, 21:00
-
TYPO3com voted on patch set 12 V +1 02/28/19, 21:13 Completed build in 12m 42s on Thu, 28 Feb, 10:13 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32431
-
Hendrik Helmken voted on patch set 12 V +1 CR +1 03/01/19, 07:08
-
Alexander Grein commented on patch set 12 V +1 CR +1 03/01/19, 10:34
Indexer.php:1441Replyshould not make any different -
Anja Leichsenring uploaded patch set 13 03/01/19, 11:14
-
Hendrik Helmken voted on patch set 13 V +1 CR +1 03/01/19, 11:26
-
TYPO3com voted on patch set 13 V +1 03/01/19, 11:29 Completed build in 15m 32s on Fri, 1 Mar, 12:29 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32447
-
Benni Mack commented on patch set 13 03/01/19, 13:20
Indexer.php:1441Reply Unresolvedjust for the sake of having it written it down. using serialize has some hard security issues within PHP core. Every time you only transfer / store data, JSON should be preferred. When we add new things, I recommend json_encode() over serialize() -
Anja Leichsenring commented on patch set 13 CR -1 03/01/19, 13:37
on it -
Anja Leichsenring uploaded patch set 14 03/01/19, 13:43
-
TYPO3com voted on patch set 14 V +1 03/01/19, 13:56 Completed build in 12m 57s on Fri, 1 Mar, 02:56 PM Test Summary: 46605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32452
-
Anja Leichsenring uploaded patch set 15 03/01/19, 13:58
-
Anja Leichsenring updated the commit message in patch set 16 03/01/19, 14:07
-
TYPO3com voted on patch set 15 V +1 03/01/19, 14:15 Completed build in 17m 23s on Fri, 1 Mar, 03:15 PM Test Summary: 46605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32453
-
Alexander Grein voted on patch set 16 V +1 CR +1 03/01/19, 14:28
-
TYPO3com voted on patch set 16 V +1 03/01/19, 14:42 Completed build in 25m 31s on Fri, 1 Mar, 03:42 PM Test Summary: 46605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32459
-
Hendrik Helmken voted on patch set 16 V +1 CR +1 03/01/19, 18:07
-
Benni Mack voted on patch set 16 V +2 CR +2 03/01/19, 19:25
-
Benni Mack merged patch set 17 03/01/19, 19:25