Review main Abandoned

59000[TASK] Upgrade Symfony-components

Stefan Neufeind CR 0 V 0 Hard +261 −121 updated 04/07/19, 09:35

Commit message

Command used:
composer update symfony/* --with-dependencies

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1418

  1. Stefan Neufeind uploaded patch set 1 11/30/18, 16:51

  2. TYPO3com voted on patch set 1 V -1 11/30/18, 17:06 Completed build in 14m 25s on Fri, 30 Nov, 06:06 PM Test Summary: 48496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30372

  3. Stefan Neufeind commented on patch set 1 CR -1 11/30/18, 17:25

    on it
  4. Stefan Neufeind uploaded patch set 2 11/30/18, 17:34

  5. TYPO3com voted on patch set 2 V +1 11/30/18, 17:45 Completed build in 10m 15s on Fri, 30 Nov, 06:44 PM Test Summary: 48496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30375

  6. Benni Mack commented on patch set 2 11/30/18, 21:58

    This is incorrect, as it says that we do not support symfony 4.1 anymore in v9. Solution is to use `composer update symfony/* --update-with-dependencies`. The commit message should always include the composer statement in use.
  7. Oliver Klee voted on patch set 2 CR +1 12/01/18, 15:17

  8. Oliver Klee voted on patch set 2 CR 0 12/01/18, 15:17

  9. Stefan Neufeind uploaded patch set 3 12/02/18, 07:48

  10. Stefan Neufeind commented on patch set 3 12/02/18, 07:50

    @Benni: Thanks, of course. I didn't consider the impact of raising the versions in composer.json - of course just updating the lock. I also tried this in the sysext/core-directory, but it didn't want to upload the adjusted composer.lock. Let's see what Bamboo thinks.
  11. TYPO3com voted on patch set 3 V +1 12/02/18, 07:57 Completed build in 09m 20s on Sun, 2 Dec, 08:57 AM Test Summary: 48496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30382

  12. Benni Mack commented on patch set 3 12/02/18, 11:33

    now that looks good :)
  13. Benni Mack voted on patch set 3 CR +1 12/02/18, 11:34

  14. Oliver Klee voted on patch set 3 CR +1 12/02/18, 11:37

  15. Stefan Neufeind uploaded patch set 4 12/07/18, 07:47

  16. Stefan Neufeind commented on patch set 4 12/07/18, 07:47

    take recent Symfony-updates into account
  17. TYPO3com voted on patch set 4 V +1 12/07/18, 07:58 Completed build in 11m 13s on Fri, 7 Dec, 08:58 AM Test Summary: 48564 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30491

  18. Stefan Neufeind abandoned the change 04/07/19, 09:35

    meanwhile a new review running in parallel, same forge-issue. see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60411