Review main Abandoned

59001[TASK] Little FIX for ArrayUtility.php

TYPO3com CR 0 V 0 Easy +1 −1 updated 12/03/18, 10:02

Commit message

Hi, i think its better to use '==' instead of '===', in this case will
also match "",[],0... So i think its bettre option to remove empty stuff
from array. What you think?

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 35

  1. TYPO3com uploaded patch set 1 11/30/18, 16:52

  2. TYPO3com voted on patch set 1 V +1 11/30/18, 17:08 Completed build in 15m 29s on Fri, 30 Nov, 06:08 PM Test Summary: 48496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30373

  3. Josef Glatz voted on patch set 1 V -1 CR -1 11/30/18, 20:01

  4. Mathias Brodala commented on patch set 1 12/03/18, 10:02

    The strict type comparison is done on purpose here since the method is supposed to drop only NULL values, nothing else. A lot of places will break if we suddenly change this behavior.
  5. Mathias Brodala abandoned the change 12/03/18, 10:02