59006[BUGFIX] Remove setDBinit, no_pconnect, dbClientCompress in install tool
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1114
-
Steffen Mächtel commented on patch set 1 11/30/18, 23:14
Cherry Picked from branch master. -
TYPO3com voted on patch set 1 V +1 11/30/18, 23:31 Completed build in 17m 13s on Sat, 1 Dec, 12:31 AM Test Summary: 79310 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3232
-
Riccardo De Contardi voted on patch set 1 CR +1 12/02/18, 15:11
-
Stefan Neufeind commented on patch set 1 CR -1 12/02/18, 18:45
SilentConfigurationUpgradeService.php (looked in 8.7) says the value is removed as SYS/setDBinit but moved to DB/Connections/Default/initCommands. So to me it looks like it shouldn't finally be removed but instead by moved/renamed? Currently the silent-upgrader seems to handle that behind the scenes? -
Stefan Neufeind commented on patch set 1 12/02/18, 18:56
This patch seems to also apply to 8.7 only. In master there is no DefaultConfiguration set for setDBinit anymore. However it is still silently migrated. Master uses $connectionParams['charset'] to set the charset to utf8 (or utf8mb4, but defaults to utf8 if nothing is set there at all). Imho for master we could still do small adjustments if we like - like only migrating the setting in the silent-upgrader if it were not our default 'SET NAMES \'UTF8\' or so. But on the other hand it wouldn't really harm to have that setting (if it is currently set) migrated over. The only culprit might imho be that you still might have the old default set in your config (which is silently migrated) and wonder why something you configure in "charset" does not take effect since it would be overwritten by whatever was migrated to initCommands. In master there is an some testcases which still refer to initCommands which should probably be adjusted. -
Stefan Neufeind commented on patch set 1 12/02/18, 19:02
I pushed a change for master that tries to remove the utf8-setting for master from the testcases. Let's see if the functionals still work as expected: https://review.typo3.org/59012 -
Ioulia Kondratovitch voted on patch set 1 V +1 12/05/18, 19:55
-
Josef Glatz commented on patch set 1 CR -1 12/06/18, 04:47
Regardless of the open discussion: This commit must not concern itself with the master branch. -
Josef Glatz voted on patch set 1 V -1 12/06/18, 04:47
-
Steffen Mächtel updated the commit message in patch set 2 12/06/18, 15:22
-
TYPO3com voted on patch set 2 V +1 12/06/18, 15:40 Completed build in 17m 31s on Thu, 6 Dec, 04:40 PM Test Summary: 79310 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3244
-
Steffen Mächtel uploaded patch set 3 12/09/18, 10:45
-
TYPO3com voted on patch set 3 V +1 12/09/18, 11:07 Completed build in 22m 34s on Sun, 9 Dec, 12:07 PM Test Summary: 79366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3286
-
Daniel Goerz abandoned the change 10/25/19, 17:47
let's not do this for 8.7 anymore, as it is in critical bug fixing mode.