Review main Merged

59018[BUGFIX] Initialize language key in AbstractPlugin

Georg Ringer CR +2 V +2 Easy +38 −12 updated 12/04/18, 05:55

Commit message

The AbstractPlugin must check SiteLanguage first for
current language key and use the TypoScript only
as fallback.

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2
    • Benni Mack +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1116

  1. Georg Ringer uploaded patch set 1 12/03/18, 17:54

  2. TYPO3com voted on patch set 1 V -1 12/03/18, 18:08 Completed build in 13m 19s on Mon, 3 Dec, 07:08 PM Test Summary: 32 of 48908 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30398

  3. Georg Ringer uploaded patch set 2 12/03/18, 20:05

  4. Benni Mack uploaded patch set 3 12/03/18, 20:06

  5. Richard Haeser voted on patch set 3 CR +1 12/03/18, 20:12

  6. Markus Klein commented on patch set 4 12/03/18, 20:19

    Published edit on patch set 3.
  7. Markus Klein voted on patch set 4 CR +1 12/03/18, 20:20

  8. Richard Haeser voted on patch set 4 CR +1 12/03/18, 20:21

  9. TYPO3com voted on patch set 2 V +1 12/03/18, 20:24 Completed build in 16m 56s on Mon, 3 Dec, 09:24 PM Test Summary: 48528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30403

  10. TYPO3com voted on patch set 3 V +1 12/03/18, 20:26 Completed build in 18m 27s on Mon, 3 Dec, 09:26 PM Test Summary: 48528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30404

  11. TYPO3com voted on patch set 4 V +1 12/03/18, 20:41 Completed build in 18m 07s on Mon, 3 Dec, 09:41 PM Test Summary: 48536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30406

  12. Benni Mack updated the commit message in patch set 5 12/03/18, 20:54

  13. TYPO3com voted on patch set 5 V +1 12/03/18, 21:07 Completed build in 13m 11s on Mon, 3 Dec, 10:07 PM Test Summary: 48536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30408

  14. Markus Klein voted on patch set 5 V +1 CR +1 12/03/18, 21:14

  15. Benni Mack voted on patch set 5 V +2 CR +2 12/04/18, 05:55

  16. Benni Mack merged patch set 6 12/04/18, 05:55