Review main Merged

59020[BUGFIX] Fix docs for site base variants to include protocol

Benni Mack CR +2 V +2 Easy +3 −3 updated 12/04/18, 07:22

Commit message

The introduction of base variants included wrong docs, as
the site base + base variants should always include the scheme
for the base URL as well.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Benni Mack uploaded patch set 1 12/04/18, 06:17

  2. TYPO3com voted on patch set 1 V +1 12/04/18, 06:30 Completed build in 12m 18s on Tue, 4 Dec, 07:30 AM Test Summary: 48548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30411

  3. Georg Ringer voted on patch set 1 V +1 CR +1 12/04/18, 06:45

  4. Benni Mack voted on patch set 1 V +2 CR +2 12/04/18, 07:22

  5. Benni Mack merged patch set 2 12/04/18, 07:22