Review main Merged

59023[BUGFIX] Remove htmlspecialchars from path_Workspace

Devid Messner CR +2 V +2 Easy +2 −1 updated 11/09/19, 20:37

Commit message

Remove htmlspecialchars in GridDataService
for path_Workspace and path_Live.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1925

  1. Devid Messner uploaded patch set 1 12/04/18, 09:21

  2. TYPO3com voted on patch set 1 V +1 12/04/18, 09:33 Completed build in 11m 32s on Tue, 4 Dec, 10:33 AM Test Summary: 48548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30421

  3. Oliver Klee updated the commit message in patch set 2 12/04/18, 09:34

  4. Oliver Klee commented on patch set 2 12/04/18, 09:35

    Is 8.7 affected as well?
  5. TYPO3com voted on patch set 2 V +1 12/04/18, 09:47 Completed build in 12m 32s on Tue, 4 Dec, 10:47 AM Test Summary: 48548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30422

  6. Georg Ringer updated the commit message in patch set 3 12/04/18, 10:22

  7. TYPO3com voted on patch set 3 V +1 12/04/18, 10:35 Completed build in 13m 04s on Tue, 4 Dec, 11:35 AM Test Summary: 48548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30423

  8. Devid Messner commented on patch set 3 12/04/18, 16:27

    Reply

    Yes, 8.7 has the same problem
  9. Guido Schmechel updated the commit message in patch set 4 12/08/18, 09:31

  10. Joerg Kummer commented on patch set 4 V +1 12/08/18, 17:43

    The changeset works as expect, but does it introduce a security risk to remove method htmlspecialchars()?
  11. Benni Mack updated the commit message in patch set 5 12/14/18, 10:17

  12. Jörg Bösche voted on patch set 5 CR +1 01/10/19, 21:05

  13. Oliver Klee updated the commit message in patch set 6 01/10/19, 23:25

  14. TYPO3com voted on patch set 6 V +1 01/10/19, 23:33 Completed build in 08m 27s on Fri, 11 Jan, 12:33 AM Test Summary: 47609 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31408

  15. Benni Mack updated the commit message in patch set 7 03/23/19, 21:23

  16. Benni Mack commented on patch set 7 03/23/19, 21:37

    I agree with joerg here. gotta investigate how this can be circumvented in JS side... If it _really_ introduces a sec risk. Just try to use a hard-coded label with some XSS in it...
  17. TYPO3com voted on patch set 7 V +1 03/23/19, 21:38 Completed build in 14m 51s on Sat, 23 Mar, 10:38 PM Test Summary: 47217 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32911

  18. Andreas Kienast commented on patch set 7 05/31/19, 12:28

    > If it _really_ introduces a sec risk. Just try to use a hard-coded label with some XSS in it... Shouldn't this work with SecurityUtility.encodeHtml()?
  19. Frank Nägler commented on patch set 7 CR -1 09/06/19, 13:22

    I see a potential security risk here, this patch needs more investigation and testing.
  20. Benni Mack commented on patch set 7 11/09/19, 17:02

    JS/TS is calling it via .text() which is safe (at least for path_Workspace).
  21. Susi Moog uploaded patch set 8 11/09/19, 17:33

  22. Susi Moog commented on patch set 8 V +1 CR +1 11/09/19, 17:35

    path_LIVE is also used via JS, but via html() that's why I'm leaving the htmlspecialchars intact (it's also not an issue...).
  23. TYPO3com voted on patch set 8 V +1 11/09/19, 17:47 Completed build in 13m 19s on Sat, 9 Nov, 05:47 PM Test Summary: 48292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38218

  24. Benni Mack voted on patch set 8 V +2 CR +2 11/09/19, 20:37

  25. Benni Mack merged patch set 9 11/09/19, 20:37