Review main Merged

59024[BUGFIX] Do not resolve languageFilePath to absolutePath

Achim Fritz CR +2 V +2 Easy +1 −3 updated 12/08/18, 12:07

Commit message

Resolving the path here breaks the localization Override
in the LocalizationFactory Class

Review

  • Code review CR +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Helmut Hummel +1
  • Verified V +2
    • Georg Ringer +2
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1117

  1. Achim Fritz uploaded patch set 1 12/04/18, 12:08

  2. TYPO3com voted on patch set 1 V -1 12/04/18, 12:21 Completed build in 12m 22s on Tue, 4 Dec, 01:21 PM Test Summary: 72 of 48960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30425

  3. Benni Mack updated the commit message in patch set 2 12/04/18, 13:40

  4. TYPO3com voted on patch set 2 V -1 12/04/18, 13:51 Completed build in 11m 28s on Tue, 4 Dec, 02:51 PM Test Summary: 72 of 48960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30433

  5. Oliver Klee updated the commit message in patch set 3 12/04/18, 15:11

  6. TYPO3com voted on patch set 3 V -1 12/04/18, 15:27 Completed build in 15m 26s on Tue, 4 Dec, 04:27 PM Test Summary: 72 of 48960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30437

  7. Achim Fritz uploaded patch set 4 12/04/18, 17:23

  8. TYPO3com voted on patch set 4 V -1 12/04/18, 17:23 Completed build in 11s on Tue, 4 Dec, 06:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30442

  9. Achim Fritz updated the commit message in patch set 5 12/04/18, 18:02

  10. TYPO3com voted on patch set 5 V -1 12/04/18, 18:02 Completed build in 09s on Tue, 4 Dec, 07:02 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30444

  11. Daniel Goerz commented on patch set 6 12/04/18, 18:08

    Published edit on patch set 5.
  12. Daniel Goerz voted on patch set 6 CR +1 12/04/18, 18:11

  13. TYPO3com voted on patch set 6 V +1 12/04/18, 18:20 Completed build in 11m 50s on Tue, 4 Dec, 07:20 PM Test Summary: 48548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30445

  14. Helmut Hummel voted on patch set 6 V +1 CR +1 12/08/18, 11:11

  15. Georg Ringer voted on patch set 6 V +2 CR +2 12/08/18, 11:30

  16. Georg Ringer merged patch set 7 12/08/18, 11:30

  17. Helmut Hummel commented on patch set 7 12/08/18, 12:07

    Thanks!