Review main Merged

59029[BUGFIX] Add support for language -1 to TCA field type slug

André Buchmann CR +2 V +2 Normal +83 −1 updated 02/01/19, 19:42

Commit message

Use default language as fallback for records with sys_language_uid = -1

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Mona Muzaffar +1
    • Susi Moog +1
  • Verified V +2
    • Anja Leichsenring +2
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1014

  1. André Buchmann uploaded patch set 1 12/04/18, 16:52

  2. TYPO3com voted on patch set 1 V +1 12/04/18, 17:03 Completed build in 11m 07s on Tue, 4 Dec, 06:03 PM Test Summary: 48548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30441

  3. Oliver Klee commented on patch set 1 12/04/18, 17:43

    Can we have tests for this?
  4. Alexander Schnitzler rebased onto patch set 2 02/01/19, 13:44

  5. TYPO3com voted on patch set 2 V +1 02/01/19, 13:58 Completed build in 12m 42s on Fri, 1 Feb, 02:58 PM Test Summary: 46932 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31914

  6. Alexander Schnitzler uploaded patch set 3 02/01/19, 14:19

  7. Alexander Schnitzler updated the commit message in patch set 4 02/01/19, 14:20

  8. TYPO3com voted on patch set 3 V +1 02/01/19, 14:33 Completed build in 13m 51s on Fri, 1 Feb, 03:33 PM Test Summary: 46940 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31918

  9. TYPO3com voted on patch set 4 V +1 02/01/19, 14:37 Completed build in 13m 29s on Fri, 1 Feb, 03:37 PM Test Summary: 46940 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31920

  10. Susi Moog voted on patch set 4 CR +1 02/01/19, 15:34

  11. Mona Muzaffar voted on patch set 4 V +1 CR +1 02/01/19, 19:42

  12. Anja Leichsenring voted on patch set 4 V +2 CR +2 02/01/19, 19:42

  13. Anja Leichsenring merged patch set 5 02/01/19, 19:42

  14. Anja Leichsenring commented on patch set 5 02/01/19, 19:42

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit d10024397899c6a822631b2b4128df982a88aaa1