59030[TASK] Add default icon overlay fields to rootline
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Josef Glatz +1
- Joerg Kummer +1
-
Verified V +2
- Markus Klein +2
- Joerg Kummer +1
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1720
-
Tim Karliczek uploaded patch set 1 12/04/18, 17:32
-
Joerg Kummer voted on patch set 1 V +1 CR +1 12/04/18, 17:35
-
TYPO3com voted on patch set 1 V +1 12/04/18, 17:43 Completed build in 10m 53s on Tue, 4 Dec, 06:43 PM Test Summary: 48548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30443
-
Georg Ringer voted on patch set 1 V +1 CR +1 12/04/18, 19:17
-
Josef Glatz voted on patch set 1 V +1 CR +1 12/04/18, 19:30
-
Markus Klein commented on patch set 1 CR -1 12/04/18, 19:46
on it -
Joerg Kummer commented on patch set 1 12/04/18, 20:09
We was also looking for https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php#L370 where 'additionalFieldsForRootline' could be reduced with this patch. -
Markus Klein uploaded patch set 2 12/04/18, 20:39
-
Markus Klein commented on patch set 2 12/04/18, 20:41
I took the liberty to refactor that piece of code to have this list of fields only twice and not three times. That includes not redeclaring those fields within a for loop all the time. -
TYPO3com voted on patch set 2 V +1 12/04/18, 20:54 Completed build in 14m 08s on Tue, 4 Dec, 09:54 PM Test Summary: 48548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30449
-
Joerg Kummer commented on patch set 2 12/04/18, 21:04
TypoScriptTemplateModuleController.php:370Field hidden is already part of 'fields for rootline' since https://review.typo3.org/#/c/58727/. Its not important or a bug, just to improve... -
Joerg Kummer voted on patch set 2 V +1 CR +1 12/04/18, 21:17
-
Markus Klein commented on patch set 3 12/04/18, 21:22
Published edit on patch set 2. -
Markus Klein commented on patch set 3 12/04/18, 21:23
Good catch Jörg, thanks, overlooked that. @Tim you may vote too here, since I will not vote as I heavily changed the patch. -
Joerg Kummer commented on patch set 3 V +1 CR +1 12/04/18, 21:27
I checked the results for change in TypoScriptTemplateModuleController cause I already have such example from former patch on this -
TYPO3com voted on patch set 3 V +1 12/04/18, 21:34 Completed build in 11m 58s on Tue, 4 Dec, 10:34 PM Test Summary: 48548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30451
-
Josef Glatz voted on patch set 3 CR +1 12/04/18, 22:06
-
Mona Muzaffar voted on patch set 3 V +1 12/07/18, 11:16
-
Markus Klein voted on patch set 3 V +2 CR +2 12/10/18, 18:34
-
Markus Klein merged patch set 4 12/10/18, 18:34