Review main Merged

59032[BUGFIX] Use proper typolink with clean TSFE for redirects

Benni Mack CR +2 V +2 Normal +47 −27 updated 01/14/19, 07:18

Commit message

Instead of re-using $GLOBALS['TSFE'] with
an already set $id and $type query
params, a new instance is created depending
on the given site.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Anja Leichsenring +1
  • Verified V +2
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1015

  1. Benni Mack uploaded patch set 1 12/04/18, 20:32

  2. TYPO3com voted on patch set 1 V -1 12/04/18, 20:46 Completed build in 14m 41s on Tue, 4 Dec, 09:46 PM Test Summary: 4 of 48960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30448

  3. Daniel Goerz uploaded patch set 2 12/05/18, 08:50

  4. TYPO3com voted on patch set 2 V -1 12/05/18, 09:01 Completed build in 10m 32s on Wed, 5 Dec, 10:01 AM Test Summary: 4 of 48960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30459

  5. Benni Mack uploaded patch set 3 12/18/18, 11:01

  6. TYPO3com voted on patch set 3 V -1 12/18/18, 11:12 Completed build in 10m 15s on Tue, 18 Dec, 12:12 PM Test Summary: 4 of 49175 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30786

  7. Benni Mack uploaded patch set 4 12/20/18, 11:53

  8. Benni Mack uploaded patch set 5 12/20/18, 11:57

  9. TYPO3com voted on patch set 4 V -1 12/20/18, 12:07 Completed build in 13m 23s on Thu, 20 Dec, 01:07 PM Test Summary: 4 of 48834 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30946

  10. TYPO3com voted on patch set 5 V +1 12/20/18, 12:11 Completed build in 12m 53s on Thu, 20 Dec, 01:11 PM Test Summary: 48419 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30947

  11. Daniel Goerz voted on patch set 5 CR +1 12/20/18, 12:47

  12. Anja Leichsenring voted on patch set 5 V +1 CR +1 01/11/19, 20:33

  13. Georg Ringer voted on patch set 5 V +2 CR +2 01/14/19, 07:18

  14. Georg Ringer merged patch set 6 01/14/19, 07:18

  15. Georg Ringer commented on patch set 6 01/14/19, 07:18

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 218cbd3c1eed21a6359a8aac7b73477276accdec