Review main Merged

59036[BUGFIX] Do not depend on global TSFE for link generation

Benni Mack CR +2 V +2 Normal +33 −28 updated 12/17/18, 12:22

Commit message

Handing in the dependency of TSFE into
AbstractLinkBuilder allows to use a custom TSFE
object, when working within middlewares (e.g. Redirects)
thus, not depending on global state directly.

As a drive-by-fix, using AbstractTypolinkBuilder now does not
generate a global TSFE anymore, which can have ugly side-effects.

Tests are now simplified because the original constructor can be
called directly instead of relying on $GLOBALS[TSFE].

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Wolf +2
    • Daniel Goerz +1
    • Jörg Bösche +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1321

  1. Benni Mack uploaded patch set 1 12/05/18, 10:40

  2. TYPO3com voted on patch set 1 V -1 12/05/18, 10:52 Completed build in 11m 17s on Wed, 5 Dec, 11:52 AM Test Summary: 24 of 48960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30461

  3. Benni Mack uploaded patch set 2 12/13/18, 06:41

  4. Benni Mack updated the commit message in patch set 3 12/13/18, 06:43

  5. TYPO3com voted on patch set 3 V -1 12/13/18, 06:54 Completed build in 10m 51s on Thu, 13 Dec, 07:54 AM Test Summary: 117 of 47488 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30632

  6. TYPO3com voted on patch set 2 V -1 12/13/18, 06:55 Completed build in 13m 44s on Thu, 13 Dec, 07:55 AM Test Summary: 56 of 48240 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30631

  7. Benni Mack updated the commit message in patch set 4 12/13/18, 08:25

  8. TYPO3com voted on patch set 4 V -1 12/13/18, 08:36 Completed build in 11m 27s on Thu, 13 Dec, 09:36 AM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30633

  9. TYPO3com voted on patch set 4 V +1 12/13/18, 09:07 Completed build in 53m 17s on Thu, 13 Dec, 10:07 AM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30633

  10. TYPO3com voted on patch set 2 V +1 12/13/18, 09:12 Completed build in 2h 44m 51s on Thu, 13 Dec, 10:12 AM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30631

  11. TYPO3com voted on patch set 3 V +1 12/13/18, 09:15 Completed build in 2h 42m 27s on Thu, 13 Dec, 10:15 AM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30632

  12. Daniel Goerz voted on patch set 4 V +1 CR +1 12/14/18, 09:35

  13. Benni Mack updated the commit message in patch set 5 12/14/18, 10:54

  14. Daniel Goerz voted on patch set 5 V +1 CR +1 12/14/18, 10:58

  15. TYPO3com voted on patch set 5 V +1 12/14/18, 11:57 Completed build in 1h 02m 26s on Fri, 14 Dec, 12:57 PM Test Summary: 48757 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30708

  16. Andreas Wolf commented on patch set 5 CR +2 12/15/18, 16:13

    AbstractTypolinkBuilder.php:207

    Unrelated side note, should we probably log a warning here?
  17. Jörg Bösche voted on patch set 5 CR +1 12/16/18, 12:50

  18. Benni Mack commented on patch set 5 12/17/18, 06:58

    AbstractTypolinkBuilder.php:207 Reply

    there is a followup patch working on that, so I'll add this to the next one.
  19. Wouter Wolters voted on patch set 5 V +2 CR +2 12/17/18, 12:22

  20. Wouter Wolters merged patch set 6 12/17/18, 12:22

  21. Wouter Wolters commented on patch set 6 12/17/18, 12:22

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit a3ecf30e179db85ec2499db2b6995f3de551cb7e