Review main Merged

59047[BUGFIX] Fix date generation in AdminPanel preview

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 12/06/18, 15:50

Commit message

This patch fixes multiple issues when generating a date in AdminPanel's
preview module:

- The order of the date segements is changed to have a valid ISO format
- Months are 0-based in JavaScript (0 = January, 11 = December), for this
  reason, +1 is added to have a valid date string

Review

  • Code review CR +2
    • Mathias Brodala +2
    • Daniel Goerz +1
    • Markus Klein +1
  • Verified V +2
    • Mathias Brodala +2
    • Daniel Goerz +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Kienast uploaded patch set 1 12/06/18, 15:24

  2. Markus Klein voted on patch set 1 V +1 CR +1 12/06/18, 15:27

  3. Mathias Brodala voted on patch set 1 CR +1 12/06/18, 15:34

  4. TYPO3com voted on patch set 1 V +1 12/06/18, 15:38 Completed build in 13m 50s on Thu, 6 Dec, 04:38 PM Test Summary: 48564 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30475

  5. Daniel Goerz voted on patch set 1 V +1 CR +1 12/06/18, 15:49

  6. Mathias Brodala voted on patch set 1 V +2 CR +2 12/06/18, 15:50

  7. Mathias Brodala merged patch set 2 12/06/18, 15:50