Review main Merged

59048[BUGFIX] Ignore wizards with no upgrades in report

Alexander Stehlik CR +2 V +2 Easy +22 −2 updated 12/08/18, 22:16

Commit message

The reports module now ignores upgrade wizards that do
not have any necessary upgrades (shouldRenderWizard property
is false).

This makes the behavior fully consistent with the install tool
because there the wizards that should not be rendered are not
displayed either.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Joerg Kummer +1
    • Wittkiel Gruppe +1
  • Verified V +2
    • Markus Klein +2
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Alexander Stehlik uploaded patch set 1 12/06/18, 21:58

  2. TYPO3com voted on patch set 1 V +1 12/06/18, 22:09 Completed build in 10m 17s on Thu, 6 Dec, 11:08 PM Test Summary: 48564 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30485

  3. Markus Klein voted on patch set 1 CR +1 12/07/18, 01:00

  4. Wittkiel Gruppe voted on patch set 1 CR +1 12/07/18, 07:10

  5. Stefan Neufeind voted on patch set 1 CR +1 12/07/18, 07:59

  6. Joerg Kummer voted on patch set 1 V +1 CR +1 12/08/18, 17:13

  7. Markus Klein voted on patch set 1 V +2 CR +2 12/08/18, 22:14

  8. Markus Klein merged patch set 2 12/08/18, 22:16