Review main Merged

59052[BUGFIX] Update ColorPicker to use cleaned minicolors hex value

Filipe DA COSTA CR +2 V +2 Easy +12 −1 updated 06/19/19, 13:46

Commit message

Force ColorPicker to use the formatted/cleaned value jQuery's minicolors
produces instead of just displaying it but still saving the raw value
the user inputs.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Henrik Elsner +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Henrik Elsner +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1518

  1. Filipe DA COSTA uploaded patch set 1 12/07/18, 12:21

  2. Filipe DA COSTA updated the commit message in patch set 2 12/07/18, 12:27

  3. TYPO3com voted on patch set 1 V +1 12/07/18, 12:48 Completed build in 25m 42s on Fri, 7 Dec, 01:48 PM Test Summary: 48564 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30501

  4. TYPO3com voted on patch set 2 V +1 12/07/18, 12:52 Completed build in 14m 30s on Fri, 7 Dec, 01:52 PM Test Summary: 48564 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30502

  5. Joerg Kummer voted on patch set 2 V +1 12/07/18, 13:54

  6. Preben Sørensen voted on patch set 2 V +1 12/08/18, 07:05

  7. Benni Mack updated the commit message in patch set 3 12/14/18, 10:16

  8. Joerg Kummer voted on patch set 3 V +1 12/14/18, 15:18

  9. Preben Sørensen voted on patch set 3 V +1 12/15/18, 09:37

  10. Daniel Goerz commented on patch set 3 V +1 03/24/19, 19:39

    ColorPicker.ts:60

    What do we need this for? Can somebody explain, please?
  11. Filipe DA COSTA commented on patch set 3 03/25/19, 08:17

    > Patch Set 3: Verified+1 > > (1 comment) If the minicolors library can't decode the value it returns an empty string. If the field was set as required we need to trigger a keyup for the backend to detect the missing value and show the red "issue dot" by the input.
  12. Daniel Goerz uploaded patch set 4 03/25/19, 08:29

  13. Daniel Goerz commented on patch set 4 V +1 CR +1 03/25/19, 08:31

    > > Patch Set 3: Verified+1 > > > > (1 comment) > > If the minicolors library can't decode the value it returns an > empty string. If the field was set as required we need to trigger a > keyup for the backend to detect the missing value and show the red > "issue dot" by the input. Thank you for explaining how to test this. I changed the code to use FormEngine.Validation.validate() instead. Please test again.
  14. TYPO3com voted on patch set 4 V +1 03/25/19, 08:40 Completed build in 10m 24s on Mon, 25 Mar, 09:40 AM Test Summary: 47221 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32937

  15. Henrik Elsner commented on patch set 4 V +1 CR +1 03/26/19, 16:05

    Nice description of the issue on forge.
  16. Daniel Goerz voted on patch set 4 V +2 CR +2 03/26/19, 18:11

  17. Daniel Goerz merged patch set 5 03/26/19, 18:11

  18. Andreas Kienast commented on patch set 5 06/19/19, 13:46

    Post -1: this patch breaks the constant editor, this is *not* a FormEngine only component!