Review TYPO3_8-7 Merged

59053[BUGFIX] Add missing translation value for Modals

Anja Leichsenring CR +2 V +2 Easy +8 −2 updated 12/07/18, 17:01

Commit message

Changes syntax for translation key and add default language value.

Review

  • Code review CR +2
    • Jan Helke +2
    • Joerg Kummer +1
    • Richard Haeser +1
    • Andreas Kienast +1
  • Verified V +2
    • Jan Helke +2
    • Joerg Kummer +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Anja Leichsenring uploaded patch set 1 12/07/18, 14:26

  2. Joerg Kummer voted on patch set 1 V +1 CR +1 12/07/18, 14:29

  3. Andreas Kienast commented on patch set 2 12/07/18, 14:34

    Published edit on patch set 1.
  4. Richard Haeser voted on patch set 2 V +1 CR +1 12/07/18, 14:40

  5. TYPO3com voted on patch set 1 V +1 12/07/18, 14:48 Completed build in 22m 14s on Fri, 7 Dec, 03:48 PM Test Summary: 79342 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3248

  6. TYPO3com voted on patch set 2 V +1 12/07/18, 14:56 Completed build in 21m 53s on Fri, 7 Dec, 03:56 PM Test Summary: 79342 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3249

  7. Joerg Kummer voted on patch set 2 V +1 CR +1 12/07/18, 16:02

  8. Andreas Kienast voted on patch set 2 CR +1 12/07/18, 16:54

  9. Jan Helke voted on patch set 2 V +2 CR +2 12/07/18, 17:01

  10. Jan Helke merged patch set 3 12/07/18, 17:01