Review TYPO3_8-7 Merged

59057[BUGFIX] Mark changes in `selectMultipleSideBySide`

Anja Leichsenring CR +2 V +2 Easy +1 −0 updated 12/07/18, 19:32

Commit message

A `selectMultipleSideBySide` field is now marked as "changed" when either
the order of items has changed or when an item has been removed.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Josef Glatz +1
    • Richard Haeser +1
  • Verified V +2
    • Anja Leichsenring +2
    • Josef Glatz +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Anja Leichsenring commented on patch set 1 12/07/18, 19:04

    Cherry Picked from branch master.
  2. Richard Haeser voted on patch set 1 CR +1 12/07/18, 19:10

  3. Anja Leichsenring commented on patch set 1 CR -1 12/07/18, 19:10

    still working on it
  4. Anja Leichsenring voted on patch set 1 CR 0 12/07/18, 19:16

  5. Josef Glatz voted on patch set 1 V +1 CR +1 12/07/18, 19:20

  6. TYPO3com voted on patch set 1 V +1 12/07/18, 19:22 Completed build in 17m 49s on Fri, 7 Dec, 08:22 PM Test Summary: 79342 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3253

  7. Richard Haeser voted on patch set 1 V +1 12/07/18, 19:27

  8. Anja Leichsenring voted on patch set 1 V +2 CR +2 12/07/18, 19:32

  9. Anja Leichsenring merged patch set 2 12/07/18, 19:32