Review TYPO3_8-7 Merged

59064[TASK] Simplify bamboo variable to label handling

Christian Kuhn CR +2 V +2 Easy +1 −2 updated 12/08/18, 16:28

Commit message

Intercept has been adapted, the variable to label handing
can be simplified a bit.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Christian Kuhn uploaded patch set 1 12/08/18, 14:02

  2. TYPO3com voted on patch set 1 V -1 12/08/18, 14:30 Completed build in 27m 15s on Sat, 8 Dec, 03:30 PM Test Summary: 79366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3265

  3. Christian Kuhn rebased onto patch set 2 12/08/18, 15:54

  4. TYPO3com voted on patch set 2 V +1 12/08/18, 16:23 Completed build in 26m 56s on Sat, 8 Dec, 05:23 PM Test Summary: 79366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3271

  5. Christian Kuhn commented on patch set 2 V +1 CR +1 12/08/18, 16:27

    pls merge.
  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 12/08/18, 16:28

  7. Anja Leichsenring merged patch set 3 12/08/18, 16:28