Review main Merged

59068[BUGFIX] Reimplement custom BE languages

Guido Schmechel CR +2 V +2 Easy +4 −1 updated 12/20/18, 12:56

Commit message

Because of a regression the backend does not load custom BE languages.
The loading order is changed so that custom languages are available
again.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2026

Show 1 earlier messages
  1. Guido Schmechel uploaded patch set 1 12/09/18, 11:13

  1. TYPO3com voted on patch set 1 V +1 12/09/18, 11:24 Completed build in 10m 22s on Sun, 9 Dec, 12:24 PM Test Summary: 48716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30554

  2. Georg Ringer voted on patch set 1 CR +1 12/09/18, 18:18

  3. Markus Klein updated the commit message in patch set 2 12/09/18, 19:58

  4. TYPO3com voted on patch set 2 V +1 12/09/18, 20:09 Completed build in 10m 29s on Sun, 9 Dec, 09:09 PM Test Summary: 48716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30561

  5. Benni Mack commented on patch set 2 CR -1 12/13/18, 06:29

    See feedback in issue
  6. Guido Schmechel commented on patch set 2 12/15/18, 14:21

    See further discussion in the ticket ;-)
  7. Guido Schmechel uploaded patch set 3 12/18/18, 20:59

  8. TYPO3com voted on patch set 3 V +1 12/18/18, 21:10 Completed build in 11m 17s on Tue, 18 Dec, 10:10 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30801

  9. Guido Schmechel commented on patch set 3 12/18/18, 21:34

    SetupModuleController.php:697 Unresolved

    Hint: v8 checks only for existing directory. So we need an or condition. Added language via install tool or a custom language. Alternative: customLanguages will be added at $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['lang']['availableLanguages']
  10. Benni Mack updated the commit message in patch set 4 12/20/18, 07:27

  11. TYPO3com voted on patch set 4 V +1 12/20/18, 07:39 Completed build in 11m 46s on Thu, 20 Dec, 08:39 AM Test Summary: 48455 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30920

  12. Benni Mack voted on patch set 4 V +1 CR +1 12/20/18, 08:09

  13. Andreas Wolf updated the commit message in patch set 5 12/20/18, 10:49

  14. Andreas Wolf voted on patch set 5 CR +1 12/20/18, 10:49

  15. TYPO3com voted on patch set 5 V -1 12/20/18, 10:49 Completed build in 05s on Thu, 20 Dec, 11:49 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30932

  16. Andreas Wolf uploaded patch set 6 12/20/18, 10:58

  17. Andreas Wolf commented on patch set 6 12/20/18, 10:59

    Rebased and (hopefully) moved the code to the correct location – there have been huge changes to TSFC recently.
  18. TYPO3com voted on patch set 6 V +1 12/20/18, 11:16 Completed build in 14m 32s on Thu, 20 Dec, 12:16 PM Test Summary: 48419 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30936

  19. Guido Schmechel commented on patch set 6 12/20/18, 11:52

    Thanks! I will have a look.
  20. Benni Mack voted on patch set 6 V +1 CR +1 12/20/18, 11:59

  21. Christian Kuhn voted on patch set 6 V +1 CR +1 12/20/18, 12:42

  22. Wouter Wolters voted on patch set 6 CR +1 12/20/18, 12:52

  23. Benni Mack voted on patch set 6 V +2 CR +2 12/20/18, 12:56

  24. Benni Mack merged patch set 7 12/20/18, 12:56

  25. Benni Mack commented on patch set 7 12/20/18, 12:56

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit b1fd068a657d4a844bb6c439d6d7e4e84a716c36