59069[WIP][BUGFIX] Avoid deprecated synchronous AJAX requests
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 8
- typo3/sysext/backend/Resources/Private/TypeScript/Storage/Persistent.ts6+41 −14
- typo3/sysext/backend/Resources/Private/TypeScript/Toolbar/SystemInformationMenu.ts+13 −11
- typo3/sysext/backend/Resources/Private/TypeScript/DateTimePicker.ts+10 −9
- typo3/sysext/backend/Resources/Private/TypeScript/ModuleMenu.ts+42 −33
- typo3/sysext/backend/Resources/Public/JavaScript/Storage/Persistent.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/SystemInformationMenu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/DateTimePicker.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ModuleMenu.js+1 −1
Review log 79
-
Andreas Kienast uploaded patch set 1 12/09/18, 17:17
-
Andreas Kienast uploaded patch set 2 12/09/18, 17:19
-
TYPO3com voted on patch set 1 V +1 12/09/18, 17:28 Completed build in 11m 09s on Sun, 9 Dec, 06:28 PM Test Summary: 48716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30556
-
Oliver Hader commented on patch set 2 12/09/18, 17:29
-
TYPO3com voted on patch set 2 V +1 12/09/18, 17:32 Completed build in 12m 53s on Sun, 9 Dec, 06:32 PM Test Summary: 48716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30557
-
Oliver Hader commented on patch set 2 12/09/18, 17:37
Persistent.ts:177This assignment won't work anymore when being invoked asynchronous... last resolve wins...Persistent.ts:178I did not look into jQuery API - does return implicit trigger resolve?Persistent.ts:183Is it possible to use the $.ajax promise already? The `resolve(me.data)`part won't work asynchronously -
Andreas Kienast commented on patch set 2 12/09/18, 17:37
Persistent.ts:32ReplyThis code was one of my first TS experience and I didn't know better back then. -
Oliver Hader commented on patch set 2 12/09/18, 17:39
Persistent.ts:33Why? We should use proper scoping instead... -
Andreas Kienast abandoned the change 05/02/19, 14:14
Persistent.ts:32