Review main Merged

59070[TASK] Add filter for be_users and be_groups

Guido Schmechel CR +2 V +2 Easy +3 −0 updated 12/12/18, 06:17

Commit message

Add textfield filter for select fields from type
"selectMultipleSideBySide" for system tables.

Affected system tables: be_groups, be_users

Review

  • Code review CR +2
    • Georg Ringer +2
    • Josef Glatz +1
    • Tomas Norre Mikkelsen +1
    • Joerg Kummer +1
    • Peter Kraume +1
    • Michael Oehlhof +1
  • Verified V +2
    • Georg Ringer +2
    • Josef Glatz +1
    • Joerg Kummer +1
    • Peter Kraume +1
    • Michael Oehlhof +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1619

  1. Guido Schmechel uploaded patch set 1 12/09/18, 20:27

  2. TYPO3com voted on patch set 1 V +1 12/09/18, 20:38 Completed build in 10m 46s on Sun, 9 Dec, 09:38 PM Test Summary: 48716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30562

  3. Guido Schmechel commented on patch set 1 12/09/18, 20:45

    Hint: Set as task to use it in version 9.
  4. Josef Glatz commented on patch set 1 V +1 CR +1 12/10/18, 04:13

    Real nice patch that can save a lot of nerves when set up an instance with many groups / users
  5. Josef Glatz commented on patch set 1 12/10/18, 04:14

    What about 8.7 too?
  6. Peter Kraume uploaded patch set 2 12/10/18, 05:54

  7. Peter Kraume commented on patch set 2 V +1 CR +1 12/10/18, 05:55

    be_users.php:68 Unresolved

    This is now defined twice for the usergroup field!
  8. TYPO3com voted on patch set 2 V +1 12/10/18, 06:05 Completed build in 10m 47s on Mon, 10 Dec, 07:05 AM Test Summary: 48716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30568

  9. Guido Schmechel commented on patch set 2 12/10/18, 07:11

    > Patch Set 1: > > (1 comment) I think that would be great. It's unfortunately not my decision ;-) The change to TASK is actually a cheat. I'll change it and we'll see.
  10. Guido Schmechel updated the commit message in patch set 3 12/10/18, 07:13

  11. TYPO3com voted on patch set 3 V +1 12/10/18, 07:24 Completed build in 10m 11s on Mon, 10 Dec, 08:24 AM Test Summary: 48716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30569

  12. Josef Glatz voted on patch set 3 V +1 CR +1 12/10/18, 07:41

  13. Joerg Kummer voted on patch set 3 V +1 CR +1 12/10/18, 07:45

  14. Peter Kraume commented on patch set 3 V +1 CR +1 12/10/18, 13:27

    Reply

    This feature would be very useful in 8.7!
  15. Michael Oehlhof voted on patch set 3 V +1 CR +1 12/10/18, 21:09

  16. Tomas Norre Mikkelsen voted on patch set 3 CR +1 12/11/18, 19:58

  17. Georg Ringer commented on patch set 3 V +2 CR +2 12/11/18, 20:59

    will check if we this is for 8.7 as well
  18. Georg Ringer merged patch set 4 12/12/18, 06:17

  19. Georg Ringer commented on patch set 4 12/12/18, 06:17

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d2584b8c309825df2c97efb24125f6269772d5ed