Review main Merged

59074[BUGFIX] Remove @ in doc comment of TypoScriptParser

Georg Ringer CR +2 V +2 Easy +1 −1 updated 12/12/18, 06:21

Commit message

To avoid exceptions by the Doctrine annotations parser, the @ character
is removed from the doc comment.

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Klee +1
    • Mathias Brodala +1
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Georg Ringer uploaded patch set 1 12/10/18, 11:19

  2. Alexander Schnitzler voted on patch set 1 V +1 CR +1 12/10/18, 11:23

  3. Mathias Brodala updated the commit message in patch set 2 12/10/18, 11:30

  4. TYPO3com voted on patch set 1 V +1 12/10/18, 11:31 Completed build in 11m 54s on Mon, 10 Dec, 12:31 PM Test Summary: 48732 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30573

  5. TYPO3com voted on patch set 2 V +1 12/10/18, 11:41 Completed build in 11m 26s on Mon, 10 Dec, 12:41 PM Test Summary: 48732 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30574

  6. Mathias Brodala voted on patch set 2 CR +1 12/10/18, 11:51

  7. Oliver Klee voted on patch set 2 CR +1 12/10/18, 13:06

  8. Benni Mack voted on patch set 2 V +2 CR +2 12/12/18, 06:21

  9. Benni Mack merged patch set 3 12/12/18, 06:21