Review main Merged

59082[BUGFIX] Check for valid FrontendInterface for page title cache

Richard Haeser CR +2 V +2 Easy +3 −3 updated 12/11/18, 09:49

Commit message

The PageTitleProviderManager will now check if the page cache object
is an instance of FrontendInterface before getting the value from cache.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Georg Ringer +1
    • Susi Moog +1
  • Verified V +2
    • Oliver Hader +2
    • Georg Ringer +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Richard Haeser uploaded patch set 1 12/10/18, 21:34

  2. TYPO3com voted on patch set 1 V +1 12/10/18, 21:46 Completed build in 12m 42s on Mon, 10 Dec, 10:46 PM Test Summary: 48732 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30581

  3. Georg Ringer voted on patch set 1 V +1 CR +1 12/11/18, 08:53

  4. Susi Moog voted on patch set 1 V +1 CR +1 12/11/18, 09:20

  5. Oliver Hader voted on patch set 1 V +2 CR +2 12/11/18, 09:49

  6. Oliver Hader merged patch set 2 12/11/18, 09:49