59083[TASK] Avoid slow array functions in loops
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Frank Nägler +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 52
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php2+3 −3
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php1+4 −3
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php1+8 −8
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php1+3 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaTypesShowitem.php1+3 −2
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php+2 −2
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php1+3 −3
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php1+3 −3
- typo3/sysext/backend/Classes/Tree/View/FolderTreeView.php1+3 −3
- typo3/sysext/backend/Classes/View/PageLayoutView.php1+4 −4
- typo3/sysext/backend/Classes/View/PageTreeView.php1+3 −3
- typo3/sysext/core/Classes/Core/Bootstrap.php2+7 −3
- typo3/sysext/core/Classes/Core/ClassLoadingInformationGenerator.php1+17 −15
- typo3/sysext/core/Classes/Database/Schema/SchemaMigrator.php1+3 −4
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php1+3 −5
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+6 −6
- typo3/sysext/core/Classes/Localization/Locales.php1+4 −4
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php1+5 −3
- typo3/sysext/core/Classes/Resource/Service/UserFileMountService.php1+3 −3
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php2+2 −2
Show 32 more files
- typo3/sysext/core/Classes/Routing/Enhancer/VariableProcessor.php1+6 −9
- typo3/sysext/core/Classes/TypoScript/TemplateService.php1+4 −3
- typo3/sysext/core/Classes/Utility/ArrayUtility.php1+4 −4
- typo3/sysext/core/Resources/PHP/ClassMapGenerator.php1+3 −3
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php2+4 −3
- typo3/sysext/extbase/Classes/Reflection/PropertyInfo/Extractor/PhpDocPropertyTypeExtractor.php1+3 −2
- typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php1+4 −4
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php6+10 −10
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php1+3 −6
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractCompositeRenderable.php2+3 −3
- typo3/sysext/form/Classes/Mvc/Configuration/YamlSource.php1+3 −3
- typo3/sysext/form/Classes/Service/TranslationService.php1+4 −4
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php2+19 −23
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php2+4 −7
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGeneratorTest.php1+18 −24
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequestTest.php1+11 −17
- typo3/sysext/frontend/Tests/Functional/Tca/ContentVisibleFieldsTest.php+5 −4
- typo3/sysext/install/Classes/Configuration/FeatureManager.php1+3 −6
- typo3/sysext/install/Classes/FolderStructure/DirectoryNode.php+6 −6
- typo3/sysext/install/Classes/Service/LocalConfigurationValueService.php2+3 −3
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php1+4 −3
- typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php1+5 −5
- typo3/sysext/reports/Classes/Report/Status/Status.php4+5 −3
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php1+4 −3
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableAdditionalFieldProvider.php+4 −2
- typo3/sysext/seo/Classes/XmlSitemap/RecordsXmlSitemapDataProvider.php+3 −3
- typo3/sysext/t3editor/Classes/Registry/AddonRegistry.php+3 −3
- typo3/sysext/t3editor/Classes/T3editor.php+6 −4
- typo3/sysext/workspaces/Classes/Dependency/ElementEntity.php1+4 −3
- typo3/sysext/workspaces/Classes/Service/Dependency/CollectionService.php+3 −6
- typo3/sysext/workspaces/Classes/Service/GridDataService.php1+1 −2
- typo3/sysext/workspaces/Classes/Service/RecordService.php+3 −3
Review log 2031
Show 36 earlier messages
-
Andreas Kienast uploaded patch set 1 12/11/18, 08:57
-
TYPO3com voted on patch set 1 V -1 12/11/18, 09:07 Completed build in 10m 36s on Tue, 11 Dec, 10:07 AM Test Summary: 10 of 49144 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30582
-
Andreas Kienast uploaded patch set 2 12/11/18, 09:14
-
TYPO3com voted on patch set 2 V -1 12/11/18, 09:26 Completed build in 12m 47s on Tue, 11 Dec, 10:26 AM Test Summary: 4 of 49144 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30583
-
Andreas Kienast uploaded patch set 3 12/11/18, 09:30
-
TYPO3com voted on patch set 3 V +1 12/11/18, 09:41 Completed build in 11m 13s on Tue, 11 Dec, 10:41 AM Test Summary: 48732 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30584
-
TYPO3com commented on patch set 2 12/11/18, 11:16 Completed build in 2h 14m 55s on Tue, 11 Dec, 12:16 PM Test Summary: 4 of 49144 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30583
-
TYPO3com commented on patch set 1 12/11/18, 11:16 Completed build in 2h 29m 44s on Tue, 11 Dec, 12:16 PM Test Summary: 10 of 49144 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30582
-
Andreas Kienast uploaded patch set 4 12/21/18, 14:59
-
TYPO3com voted on patch set 4 V +1 12/21/18, 15:09 Completed build in 10m 11s on Fri, 21 Dec, 04:09 PM Test Summary: 48176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31035
-
Andreas Kienast uploaded patch set 5 01/01/19, 18:17
-
TYPO3com voted on patch set 5 V +1 01/01/19, 18:27 Completed build in 10m 37s on Tue, 1 Jan, 07:27 PM Test Summary: 47817 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31181
-
Andreas Kienast abandoned the change 01/23/19, 14:18
Abandoned for now, might get picked up later. -
Andreas Kienast restored the change 08/05/19, 15:43
-
Andreas Kienast uploaded patch set 6 08/05/19, 15:44
-
TYPO3com voted on patch set 6 V -1 08/05/19, 15:55 Completed build in 11m 43s on Mon, 5 Aug, 03:55 PM Test Summary: 14 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35601
-
Andreas Kienast uploaded patch set 7 09/02/19, 08:31
-
TYPO3com voted on patch set 7 V +1 09/02/19, 08:41 Completed build in 09m 35s on Mon, 2 Sep, 08:41 AM Test Summary: 47252 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35982
-
Andreas Kienast uploaded patch set 8 09/02/19, 09:09
-
TYPO3com voted on patch set 8 V +1 09/02/19, 09:19 Completed build in 10m 01s on Mon, 2 Sep, 09:19 AM Test Summary: 47252 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35984
-
Andreas Kienast uploaded patch set 9 09/10/19, 07:43
-
TYPO3com voted on patch set 9 V +1 09/10/19, 07:54 Completed build in 11m 13s on Tue, 10 Sep, 07:54 AM Test Summary: 47434 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36240
-
Markus Klein commented on patch set 9 09/11/19, 09:35
ExtensionManagementService.php:224are we sure that += behaves the same as array_merge? -
Andreas Kienast commented on patch set 9 09/11/19, 09:49
ExtensionManagementService.php:224Reply UnresolvedIt does not, but there's no other possibility to merge AND unpack an array. -
Frank Nägler voted on patch set 9 V +1 CR +1 09/25/19, 09:48
-
Anja Leichsenring voted on patch set 9 V +2 CR +2 09/25/19, 09:59
-
Anja Leichsenring merged patch set 10 09/25/19, 09:59
-
Oliver Hader commented on patch set 10 09/25/19, 15:35
I'm giving up the review of the whole patch... From my POV this has not improved readability and code quality - besides that, this patch is introducing lots of new regressions... -1 Please revert this changeClipboard.php:375Unresolvedlazy coding... (see below)Clipboard.php:448Unresolvedwithout the `$lines = [[]]` above either return empty array when it's empty (superfluous array_merge in that case) - or use `array_merge([],...$lines)` (still lazy coding)NewContentElementController.php:363Unresolved...TreeController.php:196Unresolved...AbstractItemProvider.php:755Unresolved...TcaTypesShowitem.php:186Unresolved...DocumentTemplate.php:609Unresolvedno benefit since it's in the same outer foreach loop... actually it got worse...AbstractTreeView.php:351Unresolved...FolderTreeView.php:269Unresolved...PageLayoutView.php:3767Unresolved...PageTreeView.php:272Unresolved...Bootstrap.php:543Unresolved...Bootstrap.php:563Unresolved... it's more complicated now ...ClassLoadingInformationGenerator.php:72Unresolved...DataHandler.php:7822Unresolved...DataHandler.php:7823Unresolved...DataMapProcessor.php:274Unresolved...SchemaMigrator.php:176Unresolved...Locales.php:204Unresolvedside-effect - having additional item + level nowLocalizationFactory.php:120Unresolved...ResourceCompressor.php:145Unresolvedprevious array_merge order seemed to be wrong - anyway: stylesheet is not on topResourceCompressor.php:197Unresolvedside-effect - it's not on top anymore...UserFileMountService.php:124Unresolved...VariableProcessor.php:343Unresolved...TemplateService.php:1087Unresolved...ArrayUtility.php:480Unresolved...ClassMapGenerator.php:40Unresolved...RequestBuilder.php:312Unresolved...RequestBuilder.php:315Unresolved...PhpDocPropertyTypeExtractor.php:93Unresolved...LocalizationUtility.php:265Unresolved...ExtensionManagementService.php:183Unresolved...ExtensionManagementService.php:201Unresolvedside-effect - changed order of applying mergeExtensionManagementService.php:207Unresolvedside-effect - changed order of applying mergeExtensionManagementService.php:213Unresolvedside-effect - changed order of applying mergeInstallUtility.php:385Unresolved...AbstractCompositeRenderable.php:140Unresolved...AbstractCompositeRenderable.php:142Unresolvedside-effect - wrong format nowYamlSource.php:65Unresolved...TranslationService.php:628Unresolved...ContentObjectRenderer.php:5887Unresolved...ContentObjectRenderer.php:6047Unresolvedmight have side-effect - order has changedAbstractTestCase.php:75Unresolved...AbstractTestCase.php:80Unresolvedmight have side-effects - order has changedEnhancerLinkGeneratorTest.php:510Unresolved...EnhancerSiteRequestTest.php:496Unresolved...FeatureManager.php:75Unresolved...LocalConfigurationValueService.php:75Unresolved...LocalConfigurationValueService.php:140Unresolvedside-effect - different formatDatabaseRecordList.php:3725Unresolved...DeletedRecords.php:528Unresolved..Status.php:90Unresolved...Status.php:97might have side-effect - order has changedStatus.php:117Unresolvedmight have side-effect - order has changedSchedulerModuleController.php:590Unresolved... -
Oliver Hader commented on patch set 10 09/25/19, 16:11
Status.php:97ReplyDone -
Oliver Hader commented on patch set 10 09/25/19, 16:15
ElementEntity.php:397Unresolvedmight have side-effect - $this->nestedChildren not updated...GridDataService.php:168Unresolvedmight have side-effect - $defaultGridColumns is not overriding table, id, uid anymore -
Anja Leichsenring wrote 09/25/19, 16:37
Created a revert of this change as Ia31248587537a502ffdfc84761bacd7095999642