Review TYPO3_7-6 Merged

59090[SECURITY] Add feature toggle to disable record registration

Oliver Hader CR +2 V +2 Easy +33 −4 updated 12/11/18, 10:13

Commit message

The "recs" query parameter allows to write
arbitrary entries into a session, leading
to a possibility to create a reasonable amount
of frontend user sessions.

In order to prevent this situation, a new configuration
option $TYPO3_CONF_VARS[FE][enableRecordRegistration]
is added to disable the functionality completely.

The feature is disabled per default in order to apply
strong security defaults. Installations that rely on this
functionality have to manually enable the feauture and
its vulnerability by changing the according TYPO3_CONF_VARS
setting in the install tool.

A security report is added to display a warning
in the TYPO3 Backend.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 6

Review log 34

  1. Oliver Hader uploaded patch set 1 12/11/18, 09:55

  2. Oliver Hader commented on patch set 1 V +2 CR +2 12/11/18, 09:55

    Auto-approved
  3. Oliver Hader merged patch set 2 12/11/18, 09:55

  4. TYPO3com voted on patch set 1 V +1 12/11/18, 10:13 Completed build in 13m 00s on Tue, 11 Dec, 11:13 AM Test Summary: 59436 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1595