Review TYPO3_8-7 Merged

59091[SECURITY] Update library CKEditor to 4.11.1

Oliver Hader CR +2 V +2 Impossible +20507 −3059 updated 12/11/18, 10:39

Commit message

CKEditor 4.11 was released including a XSS fix where
an attacker could add invalid HTML markup by switching
to the Source mode of CKEditor and back.

Latest CKEditor version 4.11.1 is used automatically per
default. In TYPO3 v8 it is possible to select previous and
insecure version 4.7.1 due to backaward compatibility reasons.
This can be configured in Extension Manager for cke_editor.

Used commands:
  cp -r typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/ \
        typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib-47
  cd Build/
  yarn add ckeditor#4.11.1 --dev
  grunt build

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 3582

Show 3562 more files

Review log 34

  1. Oliver Hader uploaded patch set 1 12/11/18, 09:55

  2. Oliver Hader commented on patch set 1 V +2 CR +2 12/11/18, 09:55

    Auto-approved
  3. Oliver Hader merged patch set 2 12/11/18, 09:55

  4. TYPO3com voted on patch set 1 V +1 12/11/18, 10:39 Completed build in 39m 35s on Tue, 11 Dec, 11:39 AM Test Summary: 79374 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3289