59100[SECURITY] Properly escape videoId for YouTube/Vimeo
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
-
Verified V +2
- Oliver Hader +2
Issues 1
Files 6
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/VimeoHelper.php+3 −3
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/YouTubeHelper.php+3 −3
- typo3/sysext/core/Classes/Resource/Rendering/VimeoRenderer.php+40 −16
- typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php+35 −16
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php+25 −4
- typo3/sysext/core/Tests/Unit/Resource/Rendering/YouTubeRendererTest.php+23 −2
Review log 34
-
Oliver Hader uploaded patch set 1 12/11/18, 09:56
-
Oliver Hader commented on patch set 1 V +2 CR +2 12/11/18, 09:57
Auto-approved -
Oliver Hader merged patch set 2 12/11/18, 09:57
-
TYPO3com voted on patch set 1 V +1 12/11/18, 10:43 Completed build in 43m 49s on Tue, 11 Dec, 11:43 AM Test Summary: 48740 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30587