Review main Merged

59107[BUGFIX] Adjust modal window processing and RequireJS loading

Oliver Hader CR +2 V +2 Easy +11 −14 updated 12/11/18, 12:32

Commit message

Review

  • Code review CR +2
    • Oliver Hader +2
    • Markus Klein +1
  • Verified V +2
    • Oliver Hader +2
    • Christian Kuhn +1

Issues 1

Files 6

Review log 1418

  1. Oliver Hader uploaded patch set 1 12/11/18, 11:47

  2. Oliver Hader updated the commit message in patch set 2 12/11/18, 11:48

  3. Markus Klein voted on patch set 2 CR +1 12/11/18, 11:53

  4. Christian Kuhn voted on patch set 2 V +1 12/11/18, 11:55

  5. Susi Moog commented on patch set 2 V +1 CR +1 12/11/18, 11:57

    Tested install, general backend, content element creation, some modal popups.
  6. Oliver Hader uploaded patch set 3 12/11/18, 11:59

  7. TYPO3com voted on patch set 1 V +1 12/11/18, 12:00 Completed build in 12m 46s on Tue, 11 Dec, 01:00 PM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30593

  8. TYPO3com voted on patch set 2 V +1 12/11/18, 12:01 Completed build in 12m 30s on Tue, 11 Dec, 01:01 PM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30594

  9. Christian Kuhn voted on patch set 3 V +1 12/11/18, 12:07

  10. TYPO3com voted on patch set 3 V +1 12/11/18, 12:09 Completed build in 10m 25s on Tue, 11 Dec, 01:09 PM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30595

  11. Susi Moog voted on patch set 3 CR +1 12/11/18, 12:12

  12. Susi Moog voted on patch set 3 V +1 12/11/18, 12:15

  13. Oliver Hader updated the commit message in patch set 4 12/11/18, 12:17

  14. Christian Kuhn voted on patch set 4 V +1 12/11/18, 12:18

  15. Markus Klein voted on patch set 4 CR +1 12/11/18, 12:22

  16. Oliver Hader voted on patch set 4 V +2 CR +2 12/11/18, 12:31

  17. Oliver Hader merged patch set 5 12/11/18, 12:31

  18. TYPO3com voted on patch set 4 V +1 12/11/18, 12:32 Completed build in 14m 59s on Tue, 11 Dec, 01:32 PM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30596