59107[BUGFIX] Adjust modal window processing and RequireJS loading
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Markus Klein +1
-
Verified V +2
- Oliver Hader +2
- Christian Kuhn +1
Issues 1
Files 6
- typo3/sysext/backend/Resources/Private/TypeScript/ImageManipulation.ts+1 −1
- typo3/sysext/backend/Resources/Private/TypeScript/Modal.ts+6 −10
- typo3/sysext/backend/Resources/Public/JavaScript/ImageManipulation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Modal.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Modules/Router.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/RequireJSConfig.js+1 −0
Review log 1418
-
Oliver Hader uploaded patch set 1 12/11/18, 11:47
-
Oliver Hader updated the commit message in patch set 2 12/11/18, 11:48
-
Markus Klein voted on patch set 2 CR +1 12/11/18, 11:53
-
Christian Kuhn voted on patch set 2 V +1 12/11/18, 11:55
-
Susi Moog commented on patch set 2 V +1 CR +1 12/11/18, 11:57
Tested install, general backend, content element creation, some modal popups. -
Oliver Hader uploaded patch set 3 12/11/18, 11:59
-
TYPO3com voted on patch set 1 V +1 12/11/18, 12:00 Completed build in 12m 46s on Tue, 11 Dec, 01:00 PM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30593
-
TYPO3com voted on patch set 2 V +1 12/11/18, 12:01 Completed build in 12m 30s on Tue, 11 Dec, 01:01 PM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30594
-
Christian Kuhn voted on patch set 3 V +1 12/11/18, 12:07
-
TYPO3com voted on patch set 3 V +1 12/11/18, 12:09 Completed build in 10m 25s on Tue, 11 Dec, 01:09 PM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30595
-
Susi Moog voted on patch set 3 CR +1 12/11/18, 12:12
-
Susi Moog voted on patch set 3 V +1 12/11/18, 12:15
-
Oliver Hader updated the commit message in patch set 4 12/11/18, 12:17
-
Christian Kuhn voted on patch set 4 V +1 12/11/18, 12:18
-
Markus Klein voted on patch set 4 CR +1 12/11/18, 12:22
-
Oliver Hader voted on patch set 4 V +2 CR +2 12/11/18, 12:31
-
Oliver Hader merged patch set 5 12/11/18, 12:31
-
TYPO3com voted on patch set 4 V +1 12/11/18, 12:32 Completed build in 14m 59s on Tue, 11 Dec, 01:32 PM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30596