Review main Merged

5912[BUGFIX] About Modules shows HTML entities for Install Tool module

Steffen Gebert CR +2 V +2 Easy +9 −9 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Steffen Gebert +2
  • Verified V +2
    • Steffen Gebert +2

Files 1

Review log 24

  1. Gerrit wrote 10/23/11, 21:17

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. Markus Klein commented on patch set 1 10/23/11, 21:17

    Why not fixing only the & into &? I think the purpose of a none breaking space should still be preserved.
  3. Markus Klein commented on patch set 1 10/23/11, 21:17

  4. Markus Klein commented on patch set 2 10/23/11, 21:17

    Am I allowed to vote here? Owner is Steffen, last Set was committed by me.
  5. Markus Klein uploaded patch set 2 10/23/11, 21:17

  6. Markus Klein commented on patch set 2 10/23/11, 21:17

    No problem at all. If you could just remove your veto, when it is in, I'll push the new patch.
  7. Markus Klein uploaded patch set 3 10/23/11, 21:17

  8. Oliver Klee commented on patch set 2 10/23/11, 21:17

    Looks good to me, but someone else must approve
  9. Oliver Klee commented on patch set 3 10/23/11, 21:17

    Looks good to me, but someone else must approve
  10. Xavier Perseguers commented on patch set 2 10/23/11, 21:17

    I would prefer that you didn't submit this This patch needs to be recreated once https://review.typo3.org/#change,5916 is committed
  11. Xavier Perseguers uploaded patch set 4 10/23/11, 21:17

  12. Xavier Perseguers commented on patch set 4 10/23/11, 21:17

    Looks good to me, approved Just giving my review after making sure what was voted is in this patch. It fixes the new lines problem by the same occasion as lines of text within a labels should not be indented.
  13. Christian Kuhn commented on patch set 1 10/23/11, 21:17

    Verified; Looks good to me, but someone else must approve
  14. Steffen Gebert commented on patch set 1 10/23/11, 21:17

    But this doesn't work out, as it fails with a SimpleXML error (undefined entity   or so).
  15. Steffen Gebert commented on patch set 4 10/23/11, 21:17

    Looks good to me, but someone else must approve Of course, go ahead!
  16. Jigal van Hemert commented on patch set 3 V 0 10/23/11, 21:17

    by team member; Looks good to me, approved
  17. Philipp Gampe commented on patch set 2 10/23/11, 21:17

    Verified; Looks good to me, but someone else must approve
  18. Philipp Gampe commented on patch set 3 10/23/11, 21:17

    Verified; Looks good to me, but someone else must approve
  19. Mr. Jenkins commented on patch set 1 10/23/11, 21:17

  20. Mr. Jenkins commented on patch set 2 10/23/11, 21:17

  21. Mr. Jenkins commented on patch set 3 10/23/11, 21:17

  22. Mr. Jenkins commented on patch set 4 10/23/11, 21:17

  23. Steffen Gebert commented on patch set 4 V 0 10/23/11, 21:17

    by team member; Looks good to me, approved Just tested again. Still working ;)
  24. Steffen Gebert merged patch set 4 10/23/11, 21:17