59120[BUGFIX] Fix HTML in modal of OnlineMedia.ts
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Stefan Neufeind +1
- Oliver Hader +1
-
Verified V +2
- Benni Mack +2
- Stefan Neufeind +1
- Riccardo De Contardi +1
- Oliver Hader +1
- TYPO3com +1 CI
Files 4
Review log 3343
Show 1318 earlier messages
-
Georg Ringer uploaded patch set 1 12/11/18, 19:34
-
Georg Ringer uploaded patch set 2 12/11/18, 19:35
-
TYPO3com voted on patch set 1 V +1 12/11/18, 19:46 Completed build in 12m 14s on Tue, 11 Dec, 08:46 PM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30608
-
TYPO3com voted on patch set 2 V +1 12/11/18, 19:48 Completed build in 13m 25s on Tue, 11 Dec, 08:48 PM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30609
-
Susi Moog voted on patch set 2 CR +1 12/11/18, 19:51
-
Susi Moog voted on patch set 2 V +1 12/11/18, 19:52
-
Georg Ringer commented on patch set 2 CR -2 12/11/18, 19:53
must not be merged yet -
Stefan Neufeind voted on patch set 2 V +1 CR +1 12/11/18, 19:59
-
Riccardo De Contardi voted on patch set 2 V +1 12/11/18, 21:39
-
Markus Klein commented on patch set 3 12/11/18, 23:12
Published edit on patch set 2. -
Markus Klein commented on patch set 3 CR +1 12/11/18, 23:13
fixed only indentation -
TYPO3com voted on patch set 3 V +1 12/11/18, 23:23 Completed build in 11m 02s on Wed, 12 Dec, 12:23 AM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30611
-
Riccardo De Contardi commented on patch set 3 V +1 12/11/18, 23:28
test done to verify: 1) create text and media CE; 2) click on "add media by URL" -
Stefan Neufeind commented on patch set 3 V +1 CR +1 12/12/18, 08:08
reapplying vote -
Oliver Klee commented on patch set 3 CR -1 12/12/18, 13:16
This still needs an issue number. -
Riccardo De Contardi updated the commit message in patch set 4 12/13/18, 08:33
-
TYPO3com voted on patch set 4 V -1 12/13/18, 08:43 Completed build in 10m 09s on Thu, 13 Dec, 09:43 AM Test Summary: 35 of 48884 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30634
-
TYPO3com voted on patch set 4 V +1 12/13/18, 09:17 Completed build in 54m 17s on Thu, 13 Dec, 10:17 AM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30634
-
Markus Klein voted on patch set 4 CR +1 12/13/18, 15:10
-
Georg Ringer voted on patch set 4 CR 0 12/13/18, 15:10
-
TYPO3 Release Team commented on patch set 4 12/13/18, 15:48
OnlineMedia.ts:103Probably help text and allowed ext should be text-only as well, right? -
Oliver Hader commented on patch set 4 12/13/18, 16:07
Last remark was sent from wrong account -
Benni Mack commented on patch set 4 12/13/18, 20:02
OnlineMedia.ts:90we need to ensure that this is text-onlyOnlineMedia.ts:103ReplyI agree -
Benni Mack uploaded patch set 5 12/13/18, 20:15
-
Benni Mack voted on patch set 5 V +1 CR +1 12/13/18, 20:15
-
Benni Mack uploaded patch set 6 12/13/18, 20:19
-
Benni Mack voted on patch set 6 V +1 CR +1 12/13/18, 20:24
-
TYPO3com voted on patch set 5 V +1 12/13/18, 20:29 Completed build in 13m 17s on Thu, 13 Dec, 09:29 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30654
-
TYPO3com voted on patch set 6 V +1 12/13/18, 20:30 Completed build in 10m 57s on Thu, 13 Dec, 09:30 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30655
-
Benni Mack uploaded patch set 7 12/13/18, 20:39
-
Oliver Hader commented on patch set 7 12/13/18, 20:49
Modal.ts:402Not required for attributes which are applied internally using HTMLElement.setAttribute() -
Oliver Hader commented on patch set 8 12/13/18, 20:50
Published edit on patch set 7. -
Oliver Hader voted on patch set 8 CR -1 12/13/18, 20:50
-
TYPO3com voted on patch set 7 V -1 12/13/18, 20:52 Completed build in 13m 24s on Thu, 13 Dec, 09:52 PM Test Summary: 2 of 49172 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30656
-
Oliver Hader uploaded patch set 9 12/13/18, 20:54
-
Oliver Hader voted on patch set 9 V +1 CR +1 12/13/18, 20:55
-
Riccardo De Contardi voted on patch set 9 V +1 12/13/18, 20:57
-
TYPO3com voted on patch set 8 V -1 12/13/18, 21:05 Completed build in 14m 31s on Thu, 13 Dec, 10:05 PM Test Summary: 2 of 49172 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30657
-
Benni Mack voted on patch set 9 V +1 CR +1 12/13/18, 21:08
-
TYPO3com voted on patch set 9 V +1 12/13/18, 21:09 Completed build in 14m 22s on Thu, 13 Dec, 10:09 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30658
-
Benni Mack voted on patch set 9 V +2 CR +2 12/13/18, 21:10
-
Benni Mack merged patch set 10 12/13/18, 21:10
-
Stefan Neufeind voted on patch set 10 V +1 CR +1 12/14/18, 07:48