Review main Merged

59120[BUGFIX] Fix HTML in modal of OnlineMedia.ts

Georg Ringer CR +2 V +2 Easy +20 −7 updated 12/14/18, 07:48

Commit message

Allows to call the OnlineMedia modal box again.

This change also adapts the buttons within
a Modal to be text-only.
Resolves: #87144
Releases: master, 8.7
Change-Id: Id08356aad3eb319c59af1411a14131715c8159d0
Reviewed-on: https://review.typo3.org/59120
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Oliver Hader +1
  • Verified V +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Riccardo De Contardi +1
    • Oliver Hader +1
    • TYPO3com +1 CI

Files 4

Review log 3343

Show 1318 earlier messages
  1. Georg Ringer uploaded patch set 1 12/11/18, 19:34

  2. Georg Ringer uploaded patch set 2 12/11/18, 19:35

  3. TYPO3com voted on patch set 1 V +1 12/11/18, 19:46 Completed build in 12m 14s on Tue, 11 Dec, 08:46 PM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30608

  4. TYPO3com voted on patch set 2 V +1 12/11/18, 19:48 Completed build in 13m 25s on Tue, 11 Dec, 08:48 PM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30609

  5. Susi Moog voted on patch set 2 CR +1 12/11/18, 19:51

  6. Susi Moog voted on patch set 2 V +1 12/11/18, 19:52

  7. Georg Ringer commented on patch set 2 CR -2 12/11/18, 19:53

    must not be merged yet
  8. Stefan Neufeind voted on patch set 2 V +1 CR +1 12/11/18, 19:59

  9. Riccardo De Contardi voted on patch set 2 V +1 12/11/18, 21:39

  10. Markus Klein commented on patch set 3 12/11/18, 23:12

    Published edit on patch set 2.
  11. Markus Klein commented on patch set 3 CR +1 12/11/18, 23:13

    fixed only indentation
  12. TYPO3com voted on patch set 3 V +1 12/11/18, 23:23 Completed build in 11m 02s on Wed, 12 Dec, 12:23 AM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30611

  13. Riccardo De Contardi commented on patch set 3 V +1 12/11/18, 23:28

    test done to verify: 1) create text and media CE; 2) click on "add media by URL"
  14. Stefan Neufeind commented on patch set 3 V +1 CR +1 12/12/18, 08:08

    reapplying vote
  15. Oliver Klee commented on patch set 3 CR -1 12/12/18, 13:16

    This still needs an issue number.
  16. Riccardo De Contardi updated the commit message in patch set 4 12/13/18, 08:33

  17. TYPO3com voted on patch set 4 V -1 12/13/18, 08:43 Completed build in 10m 09s on Thu, 13 Dec, 09:43 AM Test Summary: 35 of 48884 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30634

  18. TYPO3com voted on patch set 4 V +1 12/13/18, 09:17 Completed build in 54m 17s on Thu, 13 Dec, 10:17 AM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30634

  1. Markus Klein voted on patch set 4 CR +1 12/13/18, 15:10

  2. Georg Ringer voted on patch set 4 CR 0 12/13/18, 15:10

  3. TYPO3 Release Team commented on patch set 4 12/13/18, 15:48

    OnlineMedia.ts:103

    Probably help text and allowed ext should be text-only as well, right?
  4. Oliver Hader commented on patch set 4 12/13/18, 16:07

    Last remark was sent from wrong account
  5. Benni Mack commented on patch set 4 12/13/18, 20:02

    OnlineMedia.ts:90

    we need to ensure that this is text-only

    OnlineMedia.ts:103 Reply

    I agree
  6. Benni Mack uploaded patch set 5 12/13/18, 20:15

  7. Benni Mack voted on patch set 5 V +1 CR +1 12/13/18, 20:15

  8. Benni Mack uploaded patch set 6 12/13/18, 20:19

  9. Benni Mack voted on patch set 6 V +1 CR +1 12/13/18, 20:24

  10. TYPO3com voted on patch set 5 V +1 12/13/18, 20:29 Completed build in 13m 17s on Thu, 13 Dec, 09:29 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30654

  11. TYPO3com voted on patch set 6 V +1 12/13/18, 20:30 Completed build in 10m 57s on Thu, 13 Dec, 09:30 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30655

  12. Benni Mack uploaded patch set 7 12/13/18, 20:39

  13. Oliver Hader commented on patch set 7 12/13/18, 20:49

    Modal.ts:402

    Not required for attributes which are applied internally using HTMLElement.setAttribute()
  14. Oliver Hader commented on patch set 8 12/13/18, 20:50

    Published edit on patch set 7.
  15. Oliver Hader voted on patch set 8 CR -1 12/13/18, 20:50

  16. TYPO3com voted on patch set 7 V -1 12/13/18, 20:52 Completed build in 13m 24s on Thu, 13 Dec, 09:52 PM Test Summary: 2 of 49172 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30656

  17. Oliver Hader uploaded patch set 9 12/13/18, 20:54

  18. Oliver Hader voted on patch set 9 V +1 CR +1 12/13/18, 20:55

  19. Riccardo De Contardi voted on patch set 9 V +1 12/13/18, 20:57

  20. TYPO3com voted on patch set 8 V -1 12/13/18, 21:05 Completed build in 14m 31s on Thu, 13 Dec, 10:05 PM Test Summary: 2 of 49172 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30657

  21. Benni Mack voted on patch set 9 V +1 CR +1 12/13/18, 21:08

  22. TYPO3com voted on patch set 9 V +1 12/13/18, 21:09 Completed build in 14m 22s on Thu, 13 Dec, 10:09 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30658

  23. Benni Mack voted on patch set 9 V +2 CR +2 12/13/18, 21:10

  24. Benni Mack merged patch set 10 12/13/18, 21:10

  25. Stefan Neufeind voted on patch set 10 V +1 CR +1 12/14/18, 07:48