59129[BUGFIX] Handle missing TSFE gracefully in TS conditions
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Markus Klein +1
- Susi Moog +1
-
Verified V +2 Done
- Daniel Goerz +2
- Markus Klein +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Tests/Functional/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+8 −0
- typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php+5 −0
- typo3/sysext/core/Classes/Exception/MissingTsfeException.phpnew+21 −0
- typo3/sysext/core/Classes/ExpressionLanguage/FunctionsProvider/Typo3ConditionFunctionsProvider.php+6 −1
- typo3/sysext/core/Documentation/Changelog/9.4/Feature-85829-ImplementSymfonyExpressionLanguageForTypoScriptConditions.rst+3 −0
Review log 1324
-
Georg Ringer uploaded patch set 1 12/12/18, 23:02
-
Georg Ringer updated the commit message in patch set 2 12/12/18, 23:05
-
Josef Glatz updated the commit message in patch set 3 12/12/18, 23:15
-
Josef Glatz commented on patch set 4 12/12/18, 23:16
Published edit on patch set 3. -
TYPO3com voted on patch set 1 V -1 12/12/18, 23:18 Completed build in 15m 41s on Thu, 13 Dec, 12:18 AM Test Summary: 54 of 48065 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30624
-
TYPO3com voted on patch set 2 V -1 12/12/18, 23:19 Completed build in 13m 54s on Thu, 13 Dec, 12:19 AM Test Summary: 157 of 49114 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30625
-
TYPO3com voted on patch set 3 V -1 12/12/18, 23:28 Completed build in 13m 06s on Thu, 13 Dec, 12:28 AM Test Summary: 275 of 48334 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30626
-
TYPO3com voted on patch set 4 V -1 12/12/18, 23:32 Completed build in 15m 50s on Thu, 13 Dec, 12:32 AM Test Summary: 1 of 48594 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30628
-
TYPO3com voted on patch set 1 V +1 12/13/18, 09:01 Completed build in 10h 14m 11s on Thu, 13 Dec, 10:01 AM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30624
-
TYPO3com voted on patch set 2 V +1 12/13/18, 09:06 Completed build in 10h 15m 00s on Thu, 13 Dec, 10:06 AM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30625
-
TYPO3com voted on patch set 3 V +1 12/13/18, 09:09 Completed build in 10h 07m 07s on Thu, 13 Dec, 10:09 AM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30626
-
TYPO3com voted on patch set 4 V +1 12/13/18, 09:09 Completed build in 10h 08m 49s on Thu, 13 Dec, 10:09 AM Test Summary: 48756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30628
-
Andreas Kienast commented on patch set 4 08/21/19, 06:44
How's the progress here? -
Frank Nägler commented on patch set 4 CR -1 10/09/19, 08:45
as mentioned in the issue, the correct condition is: [getTSFE() && getTSFE().beUserLogin == 0] But in v10 the property "beUserLogin" does not exist. Anyway, use an object (or function result) which could be null is the problem and would be the same problem in pure PHP. So checking if getTSFE() is not null is the only correct way. -
Markus Klein uploaded patch set 5 01/12/20, 12:25
-
Markus Klein uploaded patch set 6 01/12/20, 12:29
-
TYPO3com voted on patch set 5 V -1 01/12/20, 12:41 Completed build in 10m 27s on Sun, 12 Jan, 12:41 PM Test Summary: 48231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39807
-
TYPO3com voted on patch set 6 V -1 01/12/20, 12:51 Completed build in 20m 36s on Sun, 12 Jan, 12:51 PM Test Summary: 68051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39809
-
TYPO3com voted on patch set 6 V +1 01/12/20, 15:22 Completed build in 3h 12m 39s on Sun, 12 Jan, 03:22 PM Test Summary: 69194 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39809
-
Markus Klein voted on patch set 6 V +1 CR +1 01/12/20, 15:50
-
Susi Moog voted on patch set 6 V +1 CR +1 01/12/20, 16:54
-
Daniel Goerz voted on patch set 6 V +1 CR +1 01/12/20, 16:55
-
Daniel Goerz voted on patch set 6 V +2 CR +2 01/12/20, 17:16
-
Daniel Goerz merged patch set 7 01/12/20, 17:16