Review main Merged

59132[BUGFIX] Do not rewind Generator in DebuggerUtility::var_dump()

Mathias Brodala CR +2 V +2 Easy +15 −1 updated 12/13/18, 15:35

Commit message

Review

  • Code review CR +2
    • Mathias Brodala +2
    • Ralf Merz +1
    • Markus Klein +1
    • Riny van Tiggelen +1
  • Verified V +2
    • Mathias Brodala +2
    • Ralf Merz +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Mathias Brodala uploaded patch set 1 12/13/18, 14:22

  2. TYPO3com voted on patch set 1 V -1 12/13/18, 14:22 Completed build in 09s on Thu, 13 Dec, 03:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30643

  3. Mathias Brodala uploaded patch set 2 12/13/18, 14:23

  4. Mathias Brodala uploaded patch set 3 12/13/18, 14:26

  5. TYPO3com voted on patch set 2 V -1 12/13/18, 14:35 Completed build in 11m 33s on Thu, 13 Dec, 03:35 PM Test Summary: 4 of 49172 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30644

  6. TYPO3com voted on patch set 3 V +1 12/13/18, 14:39 Completed build in 13m 24s on Thu, 13 Dec, 03:39 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30645

  7. Markus Klein commented on patch set 3 V +1 CR +1 12/13/18, 15:03

    nobrainer
  8. Riny van Tiggelen voted on patch set 3 CR +1 12/13/18, 15:19

  9. Ralf Merz commented on patch set 3 CR +1 12/13/18, 15:20

    looks good by reading
  10. Ralf Merz commented on patch set 3 V +1 12/13/18, 15:33

    also run cherry picked test on local dev (Mac) successfully
  11. Mathias Brodala voted on patch set 3 V +2 CR +2 12/13/18, 15:35

  12. Mathias Brodala merged patch set 4 12/13/18, 15:35

  13. Mathias Brodala commented on patch set 4 12/13/18, 15:35

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ad29e7e2c21ac9d79fa76ff6a3c87c454c361713