Review main Abandoned

59142[BUGFIX] Remove invalid wizard identifer check

Alexander Stehlik CR 0 V 0 Easy +0 −2 updated 01/11/19, 17:42

Commit message

The install tool upgrade wizard identifier check is removed
when marking wizards undone.

The identifier can in this case either be a real wizard
identifier or the class name of a database row update wizard.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 912

  1. Alexander Stehlik uploaded patch set 1 12/13/18, 23:20

  2. Alexander Stehlik commented on patch set 1 12/13/18, 23:25

    The test here should be quite easy: try to mark for example the wizard "Scan for old "<link>" syntax in richtext and text fields and update to "<a href>"" as undone.
  3. TYPO3com voted on patch set 1 V +1 12/13/18, 23:32 Completed build in 12m 22s on Fri, 14 Dec, 12:32 AM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30665

  4. Alexander Stehlik updated the commit message in patch set 2 12/17/18, 18:07

  5. TYPO3com voted on patch set 2 V +1 12/17/18, 18:18 Completed build in 11m 13s on Mon, 17 Dec, 07:18 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30775

  6. Georg Ringer voted on patch set 2 CR +1 12/18/18, 06:13

  7. Mona Muzaffar voted on patch set 2 CR +1 01/11/19, 10:49

  8. Mona Muzaffar commented on patch set 2 CR -1 01/11/19, 11:14

    tool instead of toll
  9. Oliver Klee updated the commit message in patch set 3 01/11/19, 11:16

  10. TYPO3com voted on patch set 3 V +1 01/11/19, 11:26 Completed build in 09m 50s on Fri, 11 Jan, 12:26 PM Test Summary: 47641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31423

  11. Mona Muzaffar commented on patch set 3 01/11/19, 11:41

    Could it be possible this issue was already solved with: https://review.typo3.org/#/c/59290/ ?
  12. Anja Leichsenring abandoned the change 01/11/19, 17:42

    this is solved already, as Mona mentioned. The bug is not reproducible anymore.