Review main Abandoned

59156[BUGFIX] Support itemsProcFunc in BackendUtility::getLabelsFromItemsList

Filipe DA COSTA CR 0 V 0 Normal +44 −7 updated 11/29/21, 08:10

Commit message

Updates BackendUtility::getLabelsFromItemsList to use
GeneralUtility::callUserFunction when using itemsProcFunc.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1832

Show 47 earlier messages
  1. Filipe DA COSTA uploaded patch set 1 12/14/18, 13:53

  2. TYPO3com voted on patch set 1 V -1 12/14/18, 13:53 Completed build in 14s on Fri, 14 Dec, 02:53 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30711

  3. Filipe DA COSTA uploaded patch set 2 12/14/18, 13:55

  4. TYPO3com voted on patch set 2 V -1 12/14/18, 13:56 Completed build in 10s on Fri, 14 Dec, 02:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30712

  5. Filipe DA COSTA uploaded patch set 3 12/14/18, 14:00

  6. TYPO3com voted on patch set 3 V +1 12/14/18, 14:12 Completed build in 11m 33s on Fri, 14 Dec, 03:12 PM Test Summary: 48761 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30713

  7. Mathias Brodala commented on patch set 3 02/07/19, 13:20

    BackendUtility.php:1735

    At least this check can be left as early return.

    BackendUtility.php:1738

    Technically this is not correct since a field can have both "items" and an "itemsProcFunc" which post-processes them. So you must collect both.

    BackendUtility.php:1745

    BackendUtility.php:1748

    This can be dropped then since "items" is guaranteed to exist and be an array.
  1. Mathias Brodala voted on patch set 3 CR -1 02/07/19, 13:20

  2. Josef Glatz commented on patch set 3 CR -1 02/07/19, 14:16

    please add proper line breaks
  3. Filipe DA COSTA updated the commit message in patch set 4 02/07/19, 14:21

  4. TYPO3com voted on patch set 4 V +1 02/07/19, 14:32 Completed build in 11m 42s on Thu, 7 Feb, 03:32 PM Test Summary: 46395 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32101

  5. Mathias Brodala commented on patch set 4 CR -1 02/07/19, 15:15

    Please see my comments from PS3
  6. Filipe DA COSTA uploaded patch set 5 02/11/19, 14:35

  7. Filipe DA COSTA uploaded patch set 6 02/11/19, 14:37

  8. TYPO3com voted on patch set 5 V -1 02/11/19, 14:43 Completed build in 25s on Mon, 11 Feb, 03:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32143

  9. TYPO3com voted on patch set 6 V -1 02/11/19, 14:43 Completed build in 34s on Mon, 11 Feb, 03:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32144

  10. Filipe DA COSTA uploaded patch set 7 02/11/19, 14:59

  11. TYPO3com voted on patch set 7 V -1 02/11/19, 15:08 Completed build in 08m 41s on Mon, 11 Feb, 04:08 PM Test Summary: 2 of 46902 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32146

  12. Filipe DA COSTA rebased onto patch set 8 02/27/19, 10:44

  13. TYPO3com voted on patch set 8 V -1 02/27/19, 10:57 Completed build in 13m 39s on Wed, 27 Feb, 11:57 AM Test Summary: 2 of 46922 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32407

  14. TYPO3com commented on patch set 8 10/25/19, 19:54 Completed build in 19m 20s on Fri, 25 Oct, 07:54 PM Test Summary: 3 of 48422 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37739

  15. Benni Mack uploaded patch set 9 04/06/20, 09:37

  16. TYPO3com voted on patch set 9 V -1 04/06/20, 10:03 Completed build in 23m 42s on Mon, 6 Apr, 10:03 AM Test Summary: 2 of 73856 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2222

  17. Benni Mack updated the commit message in patch set 10 05/25/20, 18:46

  18. TYPO3com voted on patch set 10 V -1 09/02/20, 10:50 Completed build in 12m 35s on Wed, 2 Sep, 10:50 AM Test Summary: 2 of 73655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5132

  19. TYPO3com commented on patch set 10 09/03/20, 10:17 Completed build in 19m 22s on Thu, 3 Sep, 10:17 AM Test Summary: 2 of 73673 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5163

  20. Benni Mack rebased onto patch set 11 11/05/21, 08:38

  21. core-ci voted on patch set 11 V -1 11/05/21, 08:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18929

  22. Benni Mack updated the commit message in patch set 12 11/18/21, 10:45

  23. core-ci voted on patch set 12 V -1 11/18/21, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19461

  24. Benni Mack wrote 11/28/21, 22:09

    Removed reviewer Benni Mack.
  25. Filipe DA COSTA abandoned the change 11/29/21, 08:10