Review main Merged

59158[TASK] Update typo3/testing-framework from 4.11.1 to 5.0.0

Christian Kuhn CR +2 V +2 Easy +26 −22 updated 12/14/18, 18:16

Commit message

Version 5.0.0 of typo3/testing-framework brings core v10
compatibility. This fixes a 'requirements could not be resolved'
message from composer for core master branch.

composer require --dev typo3/testing-framework:~5.0.0

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 611

  1. Christian Kuhn uploaded patch set 1 12/14/18, 17:07

  2. TYPO3com voted on patch set 1 V -1 12/14/18, 17:07 Completed build in 06s on Fri, 14 Dec, 06:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30714

  3. TYPO3com commented on patch set 1 12/14/18, 17:15 Completed build in 08m 12s on Fri, 14 Dec, 06:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30714

  4. Christian Kuhn commented on patch set 1 12/14/18, 17:17

    this failed in bamboo because bamboo currently still sets composer-root-version = 9.5.0 ... fixing this now in the plan.
  5. TYPO3com commented on patch set 1 12/14/18, 17:39 Completed build in 11m 53s on Fri, 14 Dec, 06:39 PM Test Summary: 3 of 49175 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30716

  6. Christian Kuhn uploaded patch set 2 12/14/18, 17:41

  7. TYPO3com commented on patch set 1 12/14/18, 17:44 Completed build in 13m 41s on Fri, 14 Dec, 06:44 PM Test Summary: 48757 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30717

  8. TYPO3com voted on patch set 2 V +1 12/14/18, 17:55 Completed build in 13m 36s on Fri, 14 Dec, 06:55 PM Test Summary: 48757 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30718

  9. Christian Kuhn commented on patch set 2 V +1 CR +1 12/14/18, 17:56

    pls merge.
  10. Anja Leichsenring voted on patch set 2 V +2 CR +2 12/14/18, 18:16

  11. Anja Leichsenring merged patch set 3 12/14/18, 18:16