59159[BUGFIX] Always use default language for fetching web mounts
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Daniel Goerz +1
- Andreas Kienast +1
- André Buchmann +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Daniel Goerz +1
- Andreas Kienast +1
- André Buchmann +1
- TYPO3com +1 CI
Issues 4
- Bug #87165\TYPO3\CMS\Core\Authentication\BackendUserAuthentication::isInWebMount does not work for translations of web mounts for non admin users
- Bug #87223Translated root-page record of BE-User cannot be edited/saved (missing webmount)
- Bug #87985Permission issue on root page for non-admins on multilanguage environment
- Bug #86575Missing page access for root-page translations
Files 5
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+12 −1
- typo3/sysext/core/Tests/Functional/Authentication/Fixtures/be_groups.xmlnew+16 −0
- typo3/sysext/core/Tests/Functional/Authentication/Fixtures/be_users.xmlnew+46 −0
- typo3/sysext/core/Tests/Functional/Authentication/Fixtures/pages.xmlnew+29 −0
- typo3/sysext/core/Tests/Functional/Authentication/BackendUserAuthenticationTest.php2new+74 −0
Review log 2939
Show 1014 earlier messages
-
Alexander Bohndorf uploaded patch set 1 12/14/18, 17:21
-
TYPO3com voted on patch set 1 V -1 12/14/18, 17:22 Completed build in 06s on Fri, 14 Dec, 06:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30715
-
Alexander Bohndorf rebased onto patch set 2 12/17/18, 08:26
-
TYPO3com voted on patch set 2 V -1 12/17/18, 08:37 Completed build in 10m 29s on Mon, 17 Dec, 09:37 AM Test Summary: 4 of 49178 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30760
-
Alexander Bohndorf uploaded patch set 3 12/17/18, 11:32
-
TYPO3com voted on patch set 3 V +1 12/17/18, 11:43 Completed build in 10m 55s on Mon, 17 Dec, 12:43 PM Test Summary: 48763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30765
-
Simon Praetorius voted on patch set 3 V +1 CR +1 12/19/18, 17:01
-
Riccardo De Contardi commented on patch set 3 V +1 01/18/19, 23:54
tested on latest master; without the patch: when translating a page which is a mount point for the non-admin user, you get the error: "1: Attempt to modify record '[Translate to English:] test' (pages:900) without permission. Or non-existing page." (and, by the way, the translated page is created anyway, but cannot be modified). With the patch no error -
Anja Leichsenring commented on patch set 3 CR -1 02/17/19, 10:06
BackendUserAuthenticationTest.php:30it's probably no good idea to use the constant here. __DIR__ should work just fine. -
André Buchmann uploaded patch set 4 05/03/19, 08:41
-
André Buchmann commented on patch set 4 05/03/19, 08:43
Tested successfully and changed const ORIGINAL_ROOT to __DIR__BackendUserAuthenticationTest.php:30ReplyDone -
André Buchmann updated the commit message in patch set 5 05/03/19, 08:46
-
Jochen Roth commented on patch set 5 V +1 CR +1 05/03/19, 08:51
Looks good to me -
TYPO3com voted on patch set 4 V +1 05/03/19, 08:52 Completed build in 11m 05s on Fri, 3 May, 10:52 AM Test Summary: 47478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33703
-
TYPO3com voted on patch set 5 V +1 05/03/19, 09:00 Completed build in 13m 55s on Fri, 3 May, 11:00 AM Test Summary: 47478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33704
-
Tymoteusz Motylewski voted on patch set 5 CR +1 05/06/19, 09:33
-
Sven Juergens voted on patch set 5 V +1 CR +1 07/02/19, 11:11
-
Daniel Goerz uploaded patch set 6 07/02/19, 15:43
-
TYPO3com voted on patch set 6 V -1 07/02/19, 15:53 Completed build in 09m 37s on Tue, 2 Jul, 05:53 PM Test Summary: 46120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34712
-
Daniel Goerz uploaded patch set 7 07/02/19, 15:58
-
TYPO3com voted on patch set 7 V +1 07/02/19, 16:07 Completed build in 09m 18s on Tue, 2 Jul, 06:07 PM Test Summary: 46843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34714
-
Benni Mack voted on patch set 7 CR +1 07/02/19, 16:53
-
Daniel Goerz updated the commit message in patch set 8 07/02/19, 17:10
-
Daniel Goerz uploaded patch set 9 07/02/19, 17:16
-
Daniel Goerz commented on patch set 9 07/02/19, 17:17
Sorry, I accidentally cherry-picked an older patchset and reverted some things. Should be fine now. -
TYPO3com voted on patch set 8 V +1 07/02/19, 17:23 Completed build in 13m 14s on Tue, 2 Jul, 07:23 PM Test Summary: 46843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34720
-
Sven Juergens voted on patch set 9 CR +1 07/02/19, 17:23
-
TYPO3com voted on patch set 9 V +1 07/02/19, 17:26 Completed build in 10m 09s on Tue, 2 Jul, 07:26 PM Test Summary: 46843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34721
-
Daniel Goerz voted on patch set 9 V +1 CR +1 07/02/19, 17:38
-
André Buchmann voted on patch set 9 V +1 CR +1 07/05/19, 15:25
-
Anja Leichsenring uploaded patch set 10 07/05/19, 16:03
-
Andreas Kienast voted on patch set 10 V +1 CR +1 07/05/19, 16:06
-
André Buchmann voted on patch set 10 V +1 CR +1 07/05/19, 16:09
-
Daniel Goerz voted on patch set 10 V +1 CR +1 07/05/19, 16:10
-
Anja Leichsenring commented on patch set 10 CR -1 07/05/19, 16:12
wait for bamboo -
TYPO3com voted on patch set 10 V +1 07/05/19, 16:16 Completed build in 12m 56s on Fri, 5 Jul, 06:16 PM Test Summary: 46702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34822
-
Anja Leichsenring voted on patch set 10 V +2 CR +2 07/05/19, 16:17
-
Anja Leichsenring merged patch set 11 07/05/19, 16:18
-
Anja Leichsenring commented on patch set 11 08/21/19, 19:22
backport is here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61253